Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15421183
D21856.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
553 B
Referenced Files
None
Subscribers
None
D21856.diff
View Options
diff --git a/src/workflow/ArcanistDiffWorkflow.php b/src/workflow/ArcanistDiffWorkflow.php
--- a/src/workflow/ArcanistDiffWorkflow.php
+++ b/src/workflow/ArcanistDiffWorkflow.php
@@ -2361,7 +2361,7 @@
// If we track an upstream branch either directly or indirectly, use that.
$branch = $api->getBranchName();
- if (strlen($branch)) {
+ if (phutil_nonempty_string($branch)) {
$upstream_path = $api->getPathToUpstream($branch);
$remote_branch = $upstream_path->getRemoteBranchName();
if ($remote_branch !== null) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Mar 22, 9:35 PM (9 h, 17 m ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7332226
Default Alt Text
D21856.diff (553 B)
Attached To
Mode
D21856: Correct a PHP8 compatibility issue when running "arc diff" with no active branch
Attached
Detach File
Event Timeline
Log In to Comment