D16983.id40863.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D16983.id40863.diff
View Options

	diff --git a/src/applications/base/PhabricatorApplication.php b/src/applications/base/PhabricatorApplication.php
	--- a/src/applications/base/PhabricatorApplication.php
	+++ b/src/applications/base/PhabricatorApplication.php
	@@ -437,10 +437,19 @@
	if (!self::isClassInstalled($class)) {
	$result = false;
	} else {
	- $result = PhabricatorPolicyFilter::hasCapability(
	- $viewer,
	- self::getByClass($class),
	- PhabricatorPolicyCapability::CAN_VIEW);
	+ $application = self::getByClass($class);
	+ if (!$application->canUninstall()) {
	+ // If the application can not be uninstalled, always allow viewers
	+ // to see it. In particular, this allows logged-out viewers to see
	+ // Settings and load global default settings even if the install
	+ // does not allow public viewers.
	+ $result = true;
	+ } else {
	+ $result = PhabricatorPolicyFilter::hasCapability(
	+ $viewer,
	+ self::getByClass($class),
	+ PhabricatorPolicyCapability::CAN_VIEW);
	+ }
	}

	$cache->setKey($key, $result);
	diff --git a/src/applications/settings/storage/PhabricatorUserPreferences.php b/src/applications/settings/storage/PhabricatorUserPreferences.php
	--- a/src/applications/settings/storage/PhabricatorUserPreferences.php
	+++ b/src/applications/settings/storage/PhabricatorUserPreferences.php
	@@ -219,6 +219,13 @@
	}
	}

	+ switch ($this->getBuiltinKey()) {
	+ case self::BUILTIN_GLOBAL_DEFAULT:
	+ // NOTE: Without this policy exception, the logged-out viewer can not
	+ // see global preferences.
	+ return true;
	+ }
	+
	return false;
	}