Page MenuHomePhabricator

Allow logged-out users to load global preferences on installs without public viewers
ClosedPublic

Authored by epriestley on Dec 5 2016, 4:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 10:37 AM
Unknown Object (File)
Thu, Apr 4, 1:07 PM
Unknown Object (File)
Wed, Apr 3, 9:34 AM
Unknown Object (File)
Mon, Apr 1, 3:50 PM
Unknown Object (File)
Mon, Apr 1, 3:47 PM
Unknown Object (File)
Sun, Mar 31, 10:03 PM
Unknown Object (File)
Sun, Mar 31, 4:28 AM
Unknown Object (File)
Sat, Mar 30, 3:16 AM
Subscribers
None

Details

Summary

Fixes T11946. When a logged-out viewer is loading a page on a non-public install, there are two policy issues which prevent them from loading global settings:

  • They can not see the Settings application itself.
  • They can not see the global settings object.

Allow them to see Settings by making mandatory applications always visible. (This doesn't make any application pages public.)

Allow them to see the global settings object explicitly.

Test Plan

Changed default language, viewed logged-out page:

Screen Shot 2016-12-05 at 8.54.13 AM.png (1×1 px, 149 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow logged-out users to load global preferences on installs without public viewers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 5 2016, 5:11 PM
This revision was automatically updated to reflect the committed changes.