Page MenuHomePhabricator
Files F15417393

D10473.id25185.diff
No OneTemporary
Actions

D10473.id25185.diff
View Options

diff --git a/src/lint/linter/ArcanistTextLinter.php b/src/lint/linter/ArcanistTextLinter.php
--- a/src/lint/linter/ArcanistTextLinter.php
+++ b/src/lint/linter/ArcanistTextLinter.php
@@ -11,7 +11,6 @@
const LINT_EOF_NEWLINE = 4;
const LINT_BAD_CHARSET = 5;
const LINT_TRAILING_WHITESPACE = 6;
- const LINT_NO_COMMIT = 7;
const LINT_BOF_WHITESPACE = 8;
const LINT_EOF_WHITESPACE = 9;
@@ -84,7 +83,6 @@
self::LINT_EOF_NEWLINE => pht('File Does Not End in Newline'),
self::LINT_BAD_CHARSET => pht('Bad Charset'),
self::LINT_TRAILING_WHITESPACE => pht('Trailing Whitespace'),
- self::LINT_NO_COMMIT => pht('Explicit %s', '@no'.'commit'),
self::LINT_BOF_WHITESPACE => pht('Leading Whitespace at BOF'),
self::LINT_EOF_WHITESPACE => pht('Trailing Whitespace at EOF'),
);
@@ -282,20 +280,4 @@
'');
}
- private function lintNoCommit($path) {
- $data = $this->getData($path);
-
- $deadly = '@no'.'commit';
-
- $offset = strpos($data, $deadly);
- if ($offset !== false) {
- $this->raiseLintAtOffset(
- $offset,
- self::LINT_NO_COMMIT,
- 'This file is explicitly marked as "'.$deadly.'", which blocks '.
- 'commits.',
- $deadly);
- }
- }
-
}
diff --git a/src/lint/linter/__tests__/text/nocommit-hook.lint-test b/src/lint/linter/__tests__/text/nocommit-hook.lint-test
deleted file mode 100644
--- a/src/lint/linter/__tests__/text/nocommit-hook.lint-test
+++ /dev/null
@@ -1,8 +0,0 @@
-@nocommit
-~~~~~~~~~~
-error:1:1
-~~~~~~~~~~
-~~~~~~~~~~
-{
- "hook" : true
-}
\ No newline at end of file
diff --git a/src/lint/linter/__tests__/text/nocommit-nohook.lint-test b/src/lint/linter/__tests__/text/nocommit-nohook.lint-test
deleted file mode 100644
--- a/src/lint/linter/__tests__/text/nocommit-nohook.lint-test
+++ /dev/null
@@ -1,2 +0,0 @@
-@nocommit
-~~~~~~~~~~

File Metadata

Mime Type
text/plain
Expires
Fri, Mar 21, 4:50 PM (2 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7715746
Default Alt Text
D10473.id25185.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility