Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15414067
D11133.id26735.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D11133.id26735.diff
View Options
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -1041,7 +1041,6 @@
'ManiphestTaskStatus' => 'applications/maniphest/constants/ManiphestTaskStatus.php',
'ManiphestTaskStatusDatasource' => 'applications/maniphest/typeahead/ManiphestTaskStatusDatasource.php',
'ManiphestTaskStatusTestCase' => 'applications/maniphest/constants/__tests__/ManiphestTaskStatusTestCase.php',
- 'ManiphestTaskSubscriber' => 'applications/maniphest/storage/ManiphestTaskSubscriber.php',
'ManiphestTransaction' => 'applications/maniphest/storage/ManiphestTransaction.php',
'ManiphestTransactionComment' => 'applications/maniphest/storage/ManiphestTransactionComment.php',
'ManiphestTransactionEditor' => 'applications/maniphest/editor/ManiphestTransactionEditor.php',
@@ -4170,7 +4169,6 @@
'ManiphestTaskStatus' => 'ManiphestConstants',
'ManiphestTaskStatusDatasource' => 'PhabricatorTypeaheadDatasource',
'ManiphestTaskStatusTestCase' => 'PhabricatorTestCase',
- 'ManiphestTaskSubscriber' => 'ManiphestDAO',
'ManiphestTransaction' => 'PhabricatorApplicationTransaction',
'ManiphestTransactionComment' => 'PhabricatorApplicationTransactionComment',
'ManiphestTransactionEditor' => 'PhabricatorApplicationTransactionEditor',
diff --git a/src/applications/maniphest/storage/ManiphestTaskSubscriber.php b/src/applications/maniphest/storage/ManiphestTaskSubscriber.php
deleted file mode 100644
--- a/src/applications/maniphest/storage/ManiphestTaskSubscriber.php
+++ /dev/null
@@ -1,62 +0,0 @@
-<?php
-
-/**
- * Deprecated; delete me.
- */
-final class ManiphestTaskSubscriber extends ManiphestDAO {
-
- protected $taskPHID;
- protected $subscriberPHID;
-
- public function getConfiguration() {
- return array(
- self::CONFIG_IDS => self::IDS_MANUAL,
- self::CONFIG_TIMESTAMPS => false,
- self::CONFIG_COLUMN_SCHEMA => array(
- 'id' => null,
- ),
- self::CONFIG_KEY_SCHEMA => array(
- 'PRIMARY' => array(
- 'columns' => array('subscriberPHID', 'taskPHID'),
- 'unique' => true,
- ),
- 'taskPHID' => array(
- 'columns' => array('taskPHID', 'subscriberPHID'),
- 'unique' => true,
- ),
- ),
- );
- }
-
- public static function updateTaskSubscribers(ManiphestTask $task) {
- $dao = new ManiphestTaskSubscriber();
- $conn = $dao->establishConnection('w');
-
- $sql = array();
- $subscribers = $task->getCCPHIDs();
- $subscribers[] = $task->getOwnerPHID();
- $subscribers = array_unique($subscribers);
-
- foreach ($subscribers as $subscriber_phid) {
- $sql[] = qsprintf(
- $conn,
- '(%s, %s)',
- $task->getPHID(),
- $subscriber_phid);
- }
-
- queryfx(
- $conn,
- 'DELETE FROM %T WHERE taskPHID = %s',
- $dao->getTableName(),
- $task->getPHID());
- if ($sql) {
- queryfx(
- $conn,
- 'INSERT INTO %T (taskPHID, subscriberPHID) VALUES %Q',
- $dao->getTableName(),
- implode(', ', $sql));
- }
- }
-
-}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Mar 20, 10:57 PM (2 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7714578
Default Alt Text
D11133.id26735.diff (3 KB)
Attached To
Mode
D11133: Remove deprecated task subscriber class
Attached
Detach File
Event Timeline
Log In to Comment