Page MenuHomePhabricator
Files F15413809

D20920.id.diff
No OneTemporary
Actions

D20920.id.diff
View Options

diff --git a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
--- a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
+++ b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
@@ -345,40 +345,59 @@
$copy->setMilestoneNumber(1);
}
- $member_xaction = null;
- foreach ($xactions as $xaction) {
- if ($xaction->getTransactionType() !== $type_edge) {
- continue;
- }
+ $hint = null;
+ if ($this->getIsMilestone()) {
+ // See T13462. If we're creating a milestone, predict that the members
+ // of the newly created milestone will be the same as the members of the
+ // parent project, since this is the governing rule.
+
+ $parent = $copy->getParentProject();
+
+ $parent = id(new PhabricatorProjectQuery())
+ ->setViewer($this->getActor())
+ ->withPHIDs(array($parent->getPHID()))
+ ->needMembers(true)
+ ->executeOne();
+ $members = $parent->getMemberPHIDs();
+
+ $hint = array_fuse($members);
+ } else {
+ $member_xaction = null;
+ foreach ($xactions as $xaction) {
+ if ($xaction->getTransactionType() !== $type_edge) {
+ continue;
+ }
+
+ $edgetype = $xaction->getMetadataValue('edge:type');
+ if ($edgetype !== $edgetype_member) {
+ continue;
+ }
- $edgetype = $xaction->getMetadataValue('edge:type');
- if ($edgetype !== $edgetype_member) {
- continue;
+ $member_xaction = $xaction;
}
- $member_xaction = $xaction;
- }
+ if ($member_xaction) {
+ $object_phid = $object->getPHID();
+
+ if ($object_phid) {
+ $project = id(new PhabricatorProjectQuery())
+ ->setViewer($this->getActor())
+ ->withPHIDs(array($object_phid))
+ ->needMembers(true)
+ ->executeOne();
+ $members = $project->getMemberPHIDs();
+ } else {
+ $members = array();
+ }
- if ($member_xaction) {
- $object_phid = $object->getPHID();
-
- if ($object_phid) {
- $project = id(new PhabricatorProjectQuery())
- ->setViewer($this->getActor())
- ->withPHIDs(array($object_phid))
- ->needMembers(true)
- ->executeOne();
- $members = $project->getMemberPHIDs();
- } else {
- $members = array();
+ $clone_xaction = clone $member_xaction;
+ $hint = $this->getPHIDTransactionNewValue($clone_xaction, $members);
+ $hint = array_fuse($hint);
}
+ }
- $clone_xaction = clone $member_xaction;
- $hint = $this->getPHIDTransactionNewValue($clone_xaction, $members);
+ if ($hint !== null) {
$rule = new PhabricatorProjectMembersPolicyRule();
-
- $hint = array_fuse($hint);
-
PhabricatorPolicyRule::passTransactionHintToRule(
$copy,
$rule,

File Metadata

Mime Type
text/plain
Expires
Thu, Mar 20, 9:29 PM (2 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7711335
Default Alt Text
D20920.id.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility