Files F15412494

D17059.diff
No OneTemporary
Actions

Size

915 B

Referenced Files

None

Subscribers

None

D17059.diff
View Options

	diff --git a/src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php b/src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php
	--- a/src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php
	+++ b/src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php
	@@ -286,6 +286,13 @@
	$actor = $this->getActor();
	$errors = array();

	+ if (!$xactions) {
	+ // If we aren't applying new reviewer transactions, just bail. We need
	+ // reviewers to be attached to the revision continue validation, and
	+ // they won't always be (for example, when mentioning a revision).
	+ return $errors;
	+ }
	+
	$author_phid = $object->getAuthorPHID();
	$config_self_accept_key = 'differential.allow-self-accept';
	$allow_self_accept = PhabricatorEnv::getEnvConfig($config_self_accept_key);

File Metadata

Mime Type: text/plain
Expires: Thu, Mar 20, 1:18 PM (5 d, 19 h ago)
Storage Engine: blob
Storage Format: Encrypted (AES-256-CBC)
Storage Handle: 7709084
Default Alt Text: D17059.diff (915 B)

Event Timeline