Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15411315
D21614.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D21614.diff
View Options
diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -349,6 +349,9 @@
case DifferentialRevisionUpdateTransaction::TRANSACTIONTYPE:
$diff = $this->requireDiff($xaction->getNewValue(), true);
+ $this->ownersDiff = $diff;
+ $this->ownersChangesets = $diff->getChangesets();
+
// Update these denormalized index tables when we attach a new
// diff to a revision.
@@ -1299,13 +1302,6 @@
$paths[] = $path_prefix.'/'.$changeset->getFilename();
}
- // If this change affected paths, save the changesets so we can apply
- // Owners rules to them later.
- if ($paths) {
- $this->ownersDiff = $diff;
- $this->ownersChangesets = $changesets;
- }
-
// Mark this as also touching all parent paths, so you can see all pending
// changes to any file within a directory.
$all_paths = array();
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mar 20 2025, 8:59 AM (4 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7706030
Default Alt Text
D21614.diff (1 KB)
Attached To
Mode
D21614: Lift peculiar side effect of path indexing out of indexer
Attached
Detach File
Event Timeline
Log In to Comment