Page MenuHomePhabricator
Files F15410668

D8505.id.diff
No OneTemporary
Actions

D8505.id.diff
View Options

diff --git a/src/applications/differential/conduit/ConduitAPI_differential_createcomment_Method.php b/src/applications/differential/conduit/ConduitAPI_differential_createcomment_Method.php
--- a/src/applications/differential/conduit/ConduitAPI_differential_createcomment_Method.php
+++ b/src/applications/differential/conduit/ConduitAPI_differential_createcomment_Method.php
@@ -37,6 +37,7 @@
->setViewer($viewer)
->withIDs(array($request->getValue('revision_id')))
->needReviewerStatus(true)
+ ->needReviewerAuthority(true)
->executeOne();
if (!$revision) {
throw new ConduitException('ERR_BAD_REVISION');
@@ -45,7 +46,7 @@
$xactions = array();
$action = $request->getValue('action');
- if ($action && ($action != 'comment')) {
+ if ($action && ($action != 'comment') && ($action != 'none')) {
$xactions[] = id(new DifferentialTransaction())
->setTransactionType(DifferentialTransaction::TYPE_ACTION)
->setNewValue($action);
diff --git a/src/applications/differential/constants/DifferentialAction.php b/src/applications/differential/constants/DifferentialAction.php
--- a/src/applications/differential/constants/DifferentialAction.php
+++ b/src/applications/differential/constants/DifferentialAction.php
@@ -102,36 +102,6 @@
return $title;
}
- /* legacy, for just mail now */
- public static function getActionPastTenseVerb($action) {
- $verbs = array(
- self::ACTION_COMMENT => 'commented on',
- self::ACTION_ACCEPT => 'accepted',
- self::ACTION_REJECT => 'requested changes to',
- self::ACTION_RETHINK => 'planned changes to',
- self::ACTION_ABANDON => 'abandoned',
- self::ACTION_CLOSE => 'closed',
- self::ACTION_REQUEST => 'requested a review of',
- self::ACTION_RECLAIM => 'reclaimed',
- self::ACTION_UPDATE => 'updated',
- self::ACTION_RESIGN => 'resigned from',
- self::ACTION_SUMMARIZE => 'summarized',
- self::ACTION_TESTPLAN => 'explained the test plan for',
- self::ACTION_CREATE => 'created',
- self::ACTION_ADDREVIEWERS => 'added reviewers to',
- self::ACTION_ADDCCS => 'added CCs to',
- self::ACTION_CLAIM => 'commandeered',
- self::ACTION_REOPEN => 'reopened',
- DifferentialTransaction::TYPE_INLINE => 'commented on',
- );
-
- if (!empty($verbs[$action])) {
- return $verbs[$action];
- } else {
- return 'brazenly "'.$action.'ed"';
- }
- }
-
public static function getActionVerb($action) {
$verbs = array(
self::ACTION_COMMENT => pht('Comment'),

File Metadata

Mime Type
text/plain
Expires
Thu, Mar 20, 8:09 AM (2 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7330746
Default Alt Text
D8505.id.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility