Add missing needReviewerAuthority() for differential.createcomment
ClosedPublic
Actions

Authored by epriestley on Mar 12 2014, 7:40 PM.

Tags

None

Referenced Files

	F18133105: D8505.id20180.diff
	Wed, Aug 13, 10:52 PM

	F18124146: D8505.id20181.diff
	Wed, Aug 13, 12:32 PM

	F18116641: D8505.id20188.diff
	Wed, Aug 13, 7:33 AM

	F18110052: D8505.diff
	Mon, Aug 11, 3:48 PM

	F18107088: D8505.diff
	Sun, Aug 10, 11:39 PM

	F17947182: D8505.id20181.diff
	Thu, Jul 31, 3:45 PM

	Unknown Object (File)
	Jun 28 2025, 8:49 PM

	Unknown Object (File)
	Jun 15 2025, 1:05 PM

Subscribers

Details

Reviewers

btrahan
dctrwatson

Commits

Restricted Diffusion Commit
rP4173367f8765: Add missing needReviewerAuthority() for differential.createcomment

Summary

For some actions (like accept) we need to load reviewer authority so we can figure out if the actor can act on behalf of project reviewers, etc.

Test Plan

Will make @dctrwatson do it.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20180.Mar 12 2014, 7:40 PM

epriestley retitled this revision from to Add missing needReviewerAuthority() for differential.createcomment.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, dctrwatson.

epriestley added a subscriber: dctrwatson.

Herald added subscribers: epriestley, aran.Mar 12 2014, 7:40 PM

Also handle the oldschool 'none' action.
Also remove some dead code.

happycat

awesometown

btrahan accepted this revision.Mar 12 2014, 9:48 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 12 2014, 9:48 PM

Closed by commit rP4173367f8765 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

ConduitAPI_differential_createcomment_Method.php

3 lines

constants/

DifferentialAction.php

30 lines

Diff 20188

View Options

src/applications/differential/conduit/ConduitAPI_differential_createcomment_Method.php