Add missing needReviewerAuthority() for differential.createcomment
ClosedPublic
Actions

Authored by epriestley on Mar 12 2014, 7:40 PM.

Tags

None

Referenced Files

	F19826437: D8505.diff
	Sun, Mar 8, 8:13 PM

	F19821274: D8505.id20188.diff
	Fri, Mar 6, 8:25 PM

	F19817738: D8505.diff
	Thu, Mar 5, 3:10 PM

	F19794801: D8505.id.diff
	Thu, Feb 26, 9:09 PM

	F19792238: D8505.id20180.diff
	Thu, Feb 26, 9:52 AM

	F19788665: D8505.id20181.diff
	Wed, Feb 25, 4:33 PM

	F19523606: D8505.diff
	Jan 17 2026, 5:46 PM

	F19516749: D8505.id20188.diff
	Jan 15 2026, 3:28 AM

Subscribers

Details

Reviewers

btrahan
dctrwatson

Commits

Restricted Diffusion Commit
rP4173367f8765: Add missing needReviewerAuthority() for differential.createcomment

Summary

For some actions (like accept) we need to load reviewer authority so we can figure out if the actor can act on behalf of project reviewers, etc.

Test Plan

Will make @dctrwatson do it.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20180.Mar 12 2014, 7:40 PM

epriestley retitled this revision from to Add missing needReviewerAuthority() for differential.createcomment.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, dctrwatson.

epriestley added a subscriber: dctrwatson.

Herald added subscribers: epriestley, aran.Mar 12 2014, 7:40 PM

Also handle the oldschool 'none' action.
Also remove some dead code.

happycat

awesometown

btrahan accepted this revision.Mar 12 2014, 9:48 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 12 2014, 9:48 PM

Closed by commit rP4173367f8765 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

ConduitAPI_differential_createcomment_Method.php

3 lines

constants/

DifferentialAction.php

30 lines

Diff 20188

View Options

src/applications/differential/conduit/ConduitAPI_differential_createcomment_Method.php