Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15408530
D17874.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D17874.diff
View Options
diff --git a/src/applications/project/controller/PhabricatorProjectBoardViewController.php b/src/applications/project/controller/PhabricatorProjectBoardViewController.php
--- a/src/applications/project/controller/PhabricatorProjectBoardViewController.php
+++ b/src/applications/project/controller/PhabricatorProjectBoardViewController.php
@@ -837,6 +837,16 @@
->setHref($batch_edit_uri)
->setDisabled(!$can_batch_edit);
+ // Column Related Actions Below
+ //
+ $edit_uri = 'board/'.$this->id.'/edit/'.$column->getID().'/';
+ $column_items[] = id(new PhabricatorActionView())
+ ->setName(pht('Edit Column'))
+ ->setIcon('fa-pencil')
+ ->setHref($this->getApplicationURI($edit_uri))
+ ->setDisabled(!$can_edit)
+ ->setWorkflow(true);
+
$can_hide = ($can_edit && !$column->isDefaultColumn());
$hide_uri = 'board/'.$this->id.'/hide/'.$column->getID().'/';
$hide_uri = $this->getApplicationURI($hide_uri);
@@ -858,6 +868,12 @@
->setWorkflow(true);
}
+ $details_uri = 'board/'.$this->id.'/column/'.$column->getID().'/';
+ $column_items[] = id(new PhabricatorActionView())
+ ->setName(pht('Column History'))
+ ->setIcon('fa-columns')
+ ->setHref($this->getApplicationURI($details_uri));
+
$column_menu = id(new PhabricatorActionListView())
->setUser($viewer);
foreach ($column_items as $item) {
diff --git a/src/applications/project/controller/PhabricatorProjectColumnDetailController.php b/src/applications/project/controller/PhabricatorProjectColumnDetailController.php
--- a/src/applications/project/controller/PhabricatorProjectColumnDetailController.php
+++ b/src/applications/project/controller/PhabricatorProjectColumnDetailController.php
@@ -103,7 +103,7 @@
->setIcon('fa-pencil')
->setHref($this->getApplicationURI($base_uri.'edit/'.$id.'/'))
->setDisabled(!$can_edit)
- ->setWorkflow(!$can_edit));
+ ->setWorkflow(true));
return $actions;
}
diff --git a/src/applications/project/controller/PhabricatorProjectColumnEditController.php b/src/applications/project/controller/PhabricatorProjectColumnEditController.php
--- a/src/applications/project/controller/PhabricatorProjectColumnEditController.php
+++ b/src/applications/project/controller/PhabricatorProjectColumnEditController.php
@@ -51,12 +51,7 @@
$validation_exception = null;
$base_uri = '/board/'.$project_id.'/';
- if ($is_new) {
- // we want to go back to the board
- $view_uri = $this->getApplicationURI($base_uri);
- } else {
- $view_uri = $this->getApplicationURI($base_uri.'column/'.$id.'/');
- }
+ $view_uri = $this->getApplicationURI($base_uri);
if ($request->isFormPost()) {
$v_name = $request->getStr('name');
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Mar 19, 11:42 PM (2 d, 15 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7691599
Default Alt Text
D17874.diff (2 KB)
Attached To
Mode
D17874: Add Column Edit / History actions to workboard columns
Attached
Detach File
Event Timeline
Log In to Comment