D17457.id.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D17457.id.diff
View Options

	diff --git a/src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditor.php b/src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditor.php
	--- a/src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditor.php
	+++ b/src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditor.php
	@@ -57,21 +57,23 @@
	}
	break;
	case PhabricatorEditEngineConfigurationTransaction::TYPE_SUBTYPE:
	- $map = $object->getEngine()
	- ->setViewer($this->getActor())
	- ->newSubtypeMap();
	- foreach ($xactions as $xaction) {
	- $new = $xaction->getNewValue();
	-
	- if (isset($map[$new])) {
	- continue;
	+ if ($xactions) {
	+ $map = $object->getEngine()
	+ ->setViewer($this->getActor())
	+ ->newSubtypeMap();
	+ foreach ($xactions as $xaction) {
	+ $new = $xaction->getNewValue();
	+
	+ if (isset($map[$new])) {
	+ continue;
	+ }
	+
	+ $errors[] = new PhabricatorApplicationTransactionValidationError(
	+ $type,
	+ pht('Invalid'),
	+ pht('Subtype "%s" is not a valid subtype.', $new),
	+ $xaction);
	}
	-
	- $errors[] = new PhabricatorApplicationTransactionValidationError(
	- $type,
	- pht('Invalid'),
	- pht('Subtype "%s" is not a valid subtype.', $new),
	- $xaction);
	}
	break;
	}