Page MenuHomePhabricator
Differential D17457

Only validate form subtype edits if subtype transactions are present
ClosedPublic
Actions

Authored by epriestley on Mar 3 2017, 9:43 PM.

Details

Reviewers
chad
Maniphest Tasks
T12314: Support formal task subtypes (like "bug" vs "feature")
T12347: "Make Editable" for any (non-task) form causes exception: "Unable to resolve method 'newEditEngineSubtypeMap'."
Commits
rP5ed90b223591: Only validate form subtype edits if subtype transactions are present
Summary

Fixes T12347. Ref T12314. Validation gets called no matter what, but is only relevant if the form supports subtypes.

Test Plan

Marked/unmarked a Paste form as editable.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 3 2017, 9:43 PM
chad accepted this revision.Mar 3 2017, 9:44 PM
This revision is now accepted and ready to land.Mar 3 2017, 9:44 PM
Closed by commit rP5ed90b223591: Only validate form subtype edits if subtype transactions are present (authored by epriestley). · Explain WhyMar 3 2017, 9:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 41981

View Options

src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditor.php

Loading...
Phabricator · Built by Phacility