Page MenuHomePhabricator
Differential D17457

Only validate form subtype edits if subtype transactions are present
ClosedPublic
Actions

Authored by epriestley on Mar 3 2017, 9:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 4:06 PM
Unknown Object (File)
Fri, Apr 19, 2:34 AM
Unknown Object (File)
Fri, Apr 19, 2:34 AM
Unknown Object (File)
Fri, Apr 19, 2:34 AM
Unknown Object (File)
Wed, Apr 17, 3:07 PM
Unknown Object (File)
Thu, Apr 11, 7:17 AM
Unknown Object (File)
Thu, Apr 11, 3:55 AM
Unknown Object (File)
Tue, Apr 9, 2:32 AM
View All 94 Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12314: Support formal task subtypes (like "bug" vs "feature")
T12347: "Make Editable" for any (non-task) form causes exception: "Unable to resolve method 'newEditEngineSubtypeMap'."
Commits
rP5ed90b223591: Only validate form subtype edits if subtype transactions are present
Summary

Fixes T12347. Ref T12314. Validation gets called no matter what, but is only relevant if the form supports subtypes.

Test Plan

Marked/unmarked a Paste form as editable.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 3 2017, 9:43 PM
Harbormaster completed remote builds in B15884: Diff 41980.Mar 3 2017, 9:44 PM
chad accepted this revision.Mar 3 2017, 9:44 PM
This revision is now accepted and ready to land.Mar 3 2017, 9:44 PM
Closed by commit rP5ed90b223591: Only validate form subtype edits if subtype transactions are present (authored by epriestley, committed by epriestley). · Explain WhyMar 3 2017, 9:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editor/
30 lines

Diff 41981

View Options

src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditor.php

Loading...
Phabricator · Built by Phacility