Page MenuHomePhabricator
Files F15402174

D10130.id24367.diff
No OneTemporary
Actions

D10130.id24367.diff
View Options

diff --git a/src/applications/files/controller/PhabricatorFileUploadController.php b/src/applications/files/controller/PhabricatorFileUploadController.php
--- a/src/applications/files/controller/PhabricatorFileUploadController.php
+++ b/src/applications/files/controller/PhabricatorFileUploadController.php
@@ -4,11 +4,15 @@
public function processRequest() {
$request = $this->getRequest();
- $user = $request->getUser();
+ $viewer = $request->getUser();
+
+ $file = new PhabricatorFile();
$e_file = true;
$errors = array();
if ($request->isFormPost()) {
+ $view_policy = $request->getStr('viewPolicy');
+
if (!$request->getFileExists('file')) {
$e_file = pht('Required');
$errors[] = pht('You must select a file to upload.');
@@ -17,7 +21,8 @@
idx($_FILES, 'file'),
array(
'name' => $request->getStr('name'),
- 'authorPHID' => $user->getPHID(),
+ 'authorPHID' => $viewer->getPHID(),
+ 'viewPolicy' => $view_policy,
'isExplicitUpload' => true,
));
}
@@ -25,6 +30,8 @@
if (!$errors) {
return id(new AphrontRedirectResponse())->setURI($file->getInfoURI());
}
+
+ $file->setViewPolicy($view_policy);
}
$support_id = celerity_generate_unique_node_id();
@@ -38,8 +45,13 @@
'You can also upload files by dragging and dropping them from your '.
'desktop onto this page or the Phabricator home page.')));
+ $policies = id(new PhabricatorPolicyQuery())
+ ->setViewer($viewer)
+ ->setObject($file)
+ ->execute();
+
$form = id(new AphrontFormView())
- ->setUser($user)
+ ->setUser($viewer)
->setEncType('multipart/form-data')
->appendChild(
id(new AphrontFormFileControl())
@@ -51,8 +63,14 @@
id(new AphrontFormTextControl())
->setLabel(pht('Name'))
->setName('name')
- ->setValue($request->getStr('name'))
- ->setCaption(pht('Optional file display name.')))
+ ->setValue($request->getStr('name')))
+ ->appendChild(
+ id(new AphrontFormPolicyControl())
+ ->setUser($viewer)
+ ->setCapability(PhabricatorPolicyCapability::CAN_VIEW)
+ ->setPolicyObject($file)
+ ->setPolicies($policies)
+ ->setName('viewPolicy'))
->appendChild(
id(new AphrontFormSubmitControl())
->setValue(pht('Upload'))
@@ -65,7 +83,7 @@
$title = pht('Upload File');
$global_upload = id(new PhabricatorGlobalUploadTargetView())
- ->setUser($user)
+ ->setUser($viewer)
->setShowIfSupportedID($support_id);
$form_box = id(new PHUIObjectBoxView())

File Metadata

Mime Type
text/plain
Expires
Tue, Mar 18, 9:04 PM (1 w, 15 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7704246
Default Alt Text
D10130.id24367.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility