Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15401780
D21798.id51957.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
541 B
Referenced Files
None
Subscribers
None
D21798.id51957.diff
View Options
diff --git a/src/parser/PhutilURI.php b/src/parser/PhutilURI.php
--- a/src/parser/PhutilURI.php
+++ b/src/parser/PhutilURI.php
@@ -154,9 +154,9 @@
$user = $this->user;
$pass = $this->pass;
- if (strlen($user) && strlen($pass)) {
+ if (phutil_nonempty_string($user) && phutil_nonempty_string($pass)) {
$auth = rawurlencode($user).':'.rawurlencode($pass).'@';
- } else if (strlen($user)) {
+ } else if (phutil_nonempty_string($user)) {
$auth = rawurlencode($user).'@';
} else {
$auth = null;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Mar 18, 7:12 PM (3 d, 14 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7653168
Default Alt Text
D21798.id51957.diff (541 B)
Attached To
Mode
D21798: Fix more PHP 8.1 "strlen(null)" callsites in PhutilURI
Attached
Detach File
Event Timeline
Log In to Comment