Fix more PHP 8.1 "strlen(null)" callsites in PhutilURI
ClosedPublic
Actions

Authored by epriestley on May 3 2022, 7:00 PM.

Tags

None

Referenced Files

	F14002630: D21798.id51957.diff
	Fri, Oct 25, 8:49 PM

	F13997972: D21798.diff
	Thu, Oct 24, 7:04 AM

	F13970568: D21798.id.diff
	Thu, Oct 17, 8:26 AM

	Unknown Object (File)
	Wed, Oct 9, 2:29 PM

	Unknown Object (File)
	Mon, Oct 7, 2:51 PM

	Unknown Object (File)
	Mon, Oct 7, 2:50 PM

	Unknown Object (File)
	Mon, Oct 7, 2:50 PM

	Unknown Object (File)
	Mon, Oct 7, 2:40 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
T13676: Drydock may reclaim recently-used resources
Commits: rARCe5b92735c6dc: Fix more PHP 8.1 "strlen(null)" callsites in PhutilURI

Summary

Ref T13676. Ref T13588. These properties on PhutilURI have flexible types, just wrap them.

Test Plan

Built a new Drydock working copy with an HTTPS URI under PHP 8.1, see T13676.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 3 2022, 7:00 PM

epriestley created this revision.

Harbormaster completed remote builds in B25693: Diff 51956.May 3 2022, 7:00 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 3 2022, 8:42 PM

This revision was landed with ongoing or failed builds.

Closed by commit rARCe5b92735c6dc: Fix more PHP 8.1 "strlen(null)" callsites in PhutilURI (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCe5b92735c6dc: Fix more PHP 8.1 "strlen(null)" callsites in PhutilURI.

Revision Contents
Changeset List

Path

Size

src/

parser/

PhutilURI.php

4 lines

Diff 51957

View Options

Fix more PHP 8.1 "strlen(null)" callsites in PhutilURIClosedPublicActions