Page MenuHomePhabricator
Files F15401265

D17195.id41345.diff
No OneTemporary
Actions

D17195.id41345.diff
View Options

diff --git a/src/applications/audit/query/PhabricatorCommitSearchEngine.php b/src/applications/audit/query/PhabricatorCommitSearchEngine.php
--- a/src/applications/audit/query/PhabricatorCommitSearchEngine.php
+++ b/src/applications/audit/query/PhabricatorCommitSearchEngine.php
@@ -139,12 +139,8 @@
$bucket = $this->getResultBucket($query);
- $authority_phids = PhabricatorAuditCommentEditor::loadAuditPHIDsForUser(
- $viewer);
-
$template = id(new PhabricatorAuditListView())
- ->setViewer($viewer)
- ->setAuthorityPHIDs($authority_phids);
+ ->setViewer($viewer);
$views = array();
if ($bucket) {
diff --git a/src/applications/audit/view/PhabricatorAuditListView.php b/src/applications/audit/view/PhabricatorAuditListView.php
--- a/src/applications/audit/view/PhabricatorAuditListView.php
+++ b/src/applications/audit/view/PhabricatorAuditListView.php
@@ -3,16 +3,10 @@
final class PhabricatorAuditListView extends AphrontView {
private $commits;
- private $authorityPHIDs = array();
private $header;
private $noDataString;
private $highlightedAudits;
- public function setAuthorityPHIDs(array $phids) {
- $this->authorityPHIDs = $phids;
- return $this;
- }
-
public function setNoDataString($no_data_string) {
$this->noDataString = $no_data_string;
return $this;
@@ -101,28 +95,15 @@
}
$auditors = phutil_implode_html(', ', $auditors);
- $authority_audits = array_select_keys($audits, $this->authorityPHIDs);
- if ($authority_audits) {
- $audit = reset($authority_audits);
- } else {
- $audit = reset($audits);
- }
- if ($audit) {
- $reasons = $audit->getAuditReasons();
- $reasons = phutil_implode_html(', ', $reasons);
- $status_code = $audit->getAuditStatus();
- $status_text =
- PhabricatorAuditStatusConstants::getStatusName($status_code);
- $status_color =
- PhabricatorAuditStatusConstants::getStatusColor($status_code);
- $status_icon =
- PhabricatorAuditStatusConstants::getStatusIcon($status_code);
- } else {
- $reasons = null;
- $status_text = null;
- $status_color = null;
- $status_icon = null;
- }
+ $status = $commit->getAuditStatus();
+
+ $status_text =
+ PhabricatorAuditCommitStatusConstants::getStatusName($status);
+ $status_color =
+ PhabricatorAuditCommitStatusConstants::getStatusColor($status);
+ $status_icon =
+ PhabricatorAuditCommitStatusConstants::getStatusIcon($status);
+
$author_phid = $commit->getAuthorPHID();
if ($author_phid) {
$author_name = $viewer->renderHandle($author_phid);
@@ -143,8 +124,7 @@
}
if ($status_color) {
- $item->setStatusIcon(
- $status_icon.' '.$status_color, $status_text);
+ $item->setStatusIcon($status_icon.' '.$status_color, $status_text);
}
$list->addItem($item);

File Metadata

Mime Type
text/plain
Expires
Tue, Mar 18, 4:38 PM (2 d, 17 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7710134
Default Alt Text
D17195.id41345.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility