Page MenuHomePhabricator

In Audit list and Owners list, show overall commit audit status instead of semi-viewer status
ClosedPublic

Authored by epriestley on Jan 12 2017, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 2:26 PM
Unknown Object (File)
Mon, Nov 18, 5:22 AM
Unknown Object (File)
Thu, Nov 14, 12:13 AM
Unknown Object (File)
Sun, Nov 10, 12:28 PM
Unknown Object (File)
Wed, Nov 6, 7:47 AM
Unknown Object (File)
Wed, Nov 6, 6:00 AM
Unknown Object (File)
Oct 20 2024, 1:43 PM
Unknown Object (File)
Oct 19 2024, 7:17 PM
Subscribers
None

Details

Summary

Fixes T9482. Historically, Audit was somewhat confused about whether queries and views should act on the viewer's status or the object's status.

This realigns Audit to work like Differential: we show overall status for the commit, just like we show overall status for revisions. This better aligns with expectation and isn't weird/confusing, and bucketing should handle all the "what do I need to do" stuff now (or, at least, seems to have in Differential).

This is also how every other type of object works in every other application, AFAIK (all of them show object status, not viewer's-relationship-to-the-object status).

Test Plan
  • Viewed commit lists in Owners and Audit.
  • Saw commit overall statuses, not my personal status.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable