D14226.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D14226.diff
View Options

	diff --git a/src/applications/harbormaster/step/HarbormasterHTTPRequestBuildStepImplementation.php b/src/applications/harbormaster/step/HarbormasterHTTPRequestBuildStepImplementation.php
	--- a/src/applications/harbormaster/step/HarbormasterHTTPRequestBuildStepImplementation.php
	+++ b/src/applications/harbormaster/step/HarbormasterHTTPRequestBuildStepImplementation.php
	@@ -75,6 +75,12 @@
	list($status, $body, $headers) = $future->resolve();

	$header_lines = array();
	+
	+ // TODO: We don't currently preserve the entire "HTTP" response header, but
	+ // should. Once we do, reproduce it here faithfully.
	+ $status_code = $status->getStatusCode();
	+ $header_lines[] = "HTTP {$status_code}";
	+
	foreach ($headers as $header) {
	list($head, $tail) = $header;
	$header_lines[] = "{$head}: {$tail}";
	@@ -89,7 +95,7 @@
	->newLog($uri, 'http.body')
	->append($body);

	- if ($status->getStatusCode() != 200) {
	+ if ($status->isError()) {
	throw new HarbormasterBuildFailureException();
	}
	}