Acccept any HTTP 2xx status as success in Harbormaster
ClosedPublic
Actions

Authored by epriestley on Oct 2 2015, 4:13 PM.

Details

Reviewers

hach-que
chad

Maniphest Tasks

T9478: Working with harbormaster.sendmessage

Commits

Restricted Diffusion Commit
rP14d6325394bb: Acccept any HTTP 2xx status as success in Harbormaster

Summary

Ref T9478. This should probably be configurable eventually, but for now treat any 200-block status as success. Also show the result code.

Test Plan

Hit a bad URI, saw "HTTP 503" + failure.
Hit a good URI, saw "HTTP 200" + success.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34351.Oct 2 2015, 4:13 PM

epriestley retitled this revision from to Acccept any HTTP 2xx status as success in Harbormaster.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, hach-que.

epriestley added a task: T9478: Working with harbormaster.sendmessage.

chad accepted this revision.Oct 2 2015, 4:14 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 2 2015, 4:14 PM

hach-que accepted this revision.Oct 2 2015, 4:14 PM

hach-que edited edge metadata.

shipitquick

Closed by commit rP14d6325394bb: Acccept any HTTP 2xx status as success in Harbormaster (authored by epriestley, committed by epriestley). · Explain WhyOct 2 2015, 4:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

step/

HarbormasterHTTPRequestBuildStepImplementation.php

8 lines

Diff 34354

View Options

src/applications/harbormaster/step/HarbormasterHTTPRequestBuildStepImplementation.php

Acccept any HTTP 2xx status as success in HarbormasterClosedPublicActions