Page MenuHomePhabricator

Acccept any HTTP 2xx status as success in Harbormaster
ClosedPublic

Authored by epriestley on Oct 2 2015, 4:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 19, 1:14 AM
Unknown Object (File)
Sun, Jun 12, 9:52 PM
Unknown Object (File)
Sat, Jun 11, 9:00 AM
Unknown Object (File)
Apr 15 2017, 8:42 AM
Unknown Object (File)
Feb 25 2017, 4:31 PM
Unknown Object (File)
Nov 24 2016, 10:01 PM
Unknown Object (File)
Nov 2 2016, 11:31 PM
Unknown Object (File)
Sep 22 2016, 5:58 PM
Subscribers
None

Details

Summary

Ref T9478. This should probably be configurable eventually, but for now treat any 200-block status as success. Also show the result code.

Test Plan
  • Hit a bad URI, saw "HTTP 503" + failure.
  • Hit a good URI, saw "HTTP 200" + success.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Acccept any HTTP 2xx status as success in Harbormaster.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, hach-que.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 2 2015, 4:14 PM
hach-que edited edge metadata.
This revision was automatically updated to reflect the committed changes.