D15044.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D15044.diff
View Options

	diff --git a/src/applications/differential/controller/DifferentialChangesetViewController.php b/src/applications/differential/controller/DifferentialChangesetViewController.php
	--- a/src/applications/differential/controller/DifferentialChangesetViewController.php
	+++ b/src/applications/differential/controller/DifferentialChangesetViewController.php
	@@ -400,16 +400,23 @@
	private function loadCoverage(DifferentialChangeset $changeset) {
	$target_phids = $changeset->getDiff()->getBuildTargetPHIDs();
	if (!$target_phids) {
	- return array();
	+ return null;
	}

	$unit = id(new HarbormasterBuildUnitMessage())->loadAllWhere(
	'buildTargetPHID IN (%Ls)',
	$target_phids);

	+ if (!$unit) {
	+ return null;
	+ }
	+
	$coverage = array();
	foreach ($unit as $message) {
	- $test_coverage = $message->getProperty('coverage', array());
	+ $test_coverage = $message->getProperty('coverage');
	+ if ($test_coverage === null) {
	+ continue;
	+ }
	$coverage_data = idx($test_coverage, $changeset->getFileName());
	if (!strlen($coverage_data)) {
	continue;
	@@ -417,6 +424,10 @@
	$coverage[] = $coverage_data;
	}

	+ if (!$coverage) {
	+ return null;
	+ }
	+
	return ArcanistUnitTestResult::mergeCoverage($coverage);
	}