D9312.id.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D9312.id.diff
View Options

	diff --git a/src/applications/dashboard/controller/PhabricatorDashboardViewController.php b/src/applications/dashboard/controller/PhabricatorDashboardViewController.php
	--- a/src/applications/dashboard/controller/PhabricatorDashboardViewController.php
	+++ b/src/applications/dashboard/controller/PhabricatorDashboardViewController.php
	@@ -26,10 +26,14 @@
	$crumbs = $this->buildApplicationCrumbs();
	$crumbs->addTextCrumb(pht('Dashboard %d', $dashboard->getID()));

	- $rendered_dashboard = id(new PhabricatorDashboardRenderingEngine())
	- ->setViewer($viewer)
	- ->setDashboard($dashboard)
	- ->renderDashboard();
	+ if ($dashboard->getPanelPHIDs()) {
	+ $rendered_dashboard = id(new PhabricatorDashboardRenderingEngine())
	+ ->setViewer($viewer)
	+ ->setDashboard($dashboard)
	+ ->renderDashboard();
	+ } else {
	+ $rendered_dashboard = $this->buildEmptyView();
	+ }

	return $this->buildApplicationPage(
	array(
	@@ -50,9 +54,24 @@
	id(new PHUIListItemView())
	->setIcon('fa-th')
	->setName(pht('Manage Dashboard'))
	- ->setHref($this->getApplicationURI()."manage/{$id}/"));
	+ ->setHref($this->getApplicationURI("manage/{$id}/")));

	return $crumbs;
	}

	+ public function buildEmptyView() {
	+ $id = $this->id;
	+ $manage_uri = $this->getApplicationURI("manage/{$id}/");
	+
	+ return id(new AphrontErrorView())
	+ ->setSeverity(AphrontErrorView::SEVERITY_NODATA)
	+ ->appendChild(
	+ pht('This dashboard has no panels '.
	+ 'yet. Use %s to add panels.',
	+ phutil_tag(
	+ 'a',
	+ array('href'=>$manage_uri),
	+ pht('Manage Dashboard'))));
	+ }
	+
	}