Fixes T5177. Not sure if checking for panelPHIDs is right, but seemed like a better choice than adding a new property on dashboard.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T5177: Create an empty state for dashboards
- Commits
- Restricted Diffusion Commit
rP92ccadaa42d2: Create an empty state for dashboards
Create dashboard with no panels. Go to view dashboard. "view" page should have a placeholder that directs user to Manage Dashboard
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Two teeny tiny nitpicks.
| src/applications/dashboard/controller/PhabricatorDashboardViewController.php | ||
|---|---|---|
| 57–77 | This is verrrry nitpicky, but technically these should be: $this->getApplicationURI("x/y/");...not: $this->getApplicationURI()."x/y/"; There's not much practical difference, but the method does some path normalization and passing the path as an argument is generally more consistent. | |
| 75 | This call to render() should be unnecessary. (Long ago a lot of things needed to have render() called, so old code still has calls, but in modern code it is usually called implicitly by the rendering pipeline.) | |