Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15399380
D21303.id50720.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D21303.id50720.diff
View Options
diff --git a/src/workflow/ArcanistDiffWorkflow.php b/src/workflow/ArcanistDiffWorkflow.php
--- a/src/workflow/ArcanistDiffWorkflow.php
+++ b/src/workflow/ArcanistDiffWorkflow.php
@@ -264,9 +264,6 @@
'skip-staging' => array(
'help' => pht('Do not copy changes to the staging area.'),
),
- 'ignore-unsound-tests' => array(
- 'help' => pht('Ignore unsound test failures without prompting.'),
- ),
'base' => array(
'param' => 'rules',
'help' => pht('Additional rules for determining base revision.'),
@@ -1207,22 +1204,20 @@
pht('No unit test failures.'));
break;
case ArcanistUnitWorkflow::RESULT_UNSOUND:
- if ($this->getArgument('ignore-unsound-tests')) {
- echo phutil_console_format(
- "<bg:yellow>** %s **</bg> %s\n",
- pht('UNIT UNSOUND'),
- pht(
- 'Unit testing raised errors, but all '.
- 'failing tests are unsound.'));
- } else {
- $continue = phutil_console_confirm(
- pht(
- 'Unit test results included failures, but all failing tests '.
- 'are known to be unsound. Ignore unsound test failures?'));
- if (!$continue) {
- throw new ArcanistUserAbortException();
- }
+ $continue = phutil_console_confirm(
+ pht(
+ 'Unit test results included failures, but all failing tests '.
+ 'are known to be unsound. Ignore unsound test failures?'));
+ if (!$continue) {
+ throw new ArcanistUserAbortException();
}
+
+ echo phutil_console_format(
+ "<bg:yellow>** %s **</bg> %s\n",
+ pht('UNIT UNSOUND'),
+ pht(
+ 'Unit testing raised errors, but all '.
+ 'failing tests are unsound.'));
break;
case ArcanistUnitWorkflow::RESULT_FAIL:
$this->console->writeOut(
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Mar 18, 4:18 AM (2 w, 16 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7709364
Default Alt Text
D21303.id50720.diff (1 KB)
Attached To
Mode
D21303: Remove "--ignore-unsound-tests" from "arc diff"
Attached
Detach File
Event Timeline
Log In to Comment