Page MenuHomePhabricator

D11834.diff
No OneTemporary

D11834.diff

diff --git a/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php b/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php
--- a/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php
+++ b/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php
@@ -168,43 +168,50 @@
$title = $document->getTitle();
- $type_name = $document->getSignatureTypeName();
- $type_icon = $document->getSignatureTypeIcon();
-
$item = id(new PHUIObjectItemView())
->setObjectName($document->getMonogram())
->setHeader($title)
->setHref('/'.$document->getMonogram())
- ->setObject($document)
- ->addIcon($type_icon, $type_name)
- ->addIcon(
- 'fa-pencil grey',
- pht('Version %d (%s)', $document->getVersions(), $last_updated));
-
- if ($viewer->getPHID()) {
- $signature = $document->getUserSignature($viewer->getPHID());
- } else {
- $signature = null;
- }
+ ->setObject($document);
- if ($signature) {
- $item->addAttribute(
- array(
- id(new PHUIIconView())->setIconFont('fa-check-square-o', 'green'),
- ' ',
- pht(
- 'Signed on %s',
- phabricator_date($signature->getDateCreated(), $viewer)),
- ));
+ $no_signatures = LegalpadDocument::SIGNATURE_TYPE_NONE;
+ if ($document->getSignatureType() == $no_signatures) {
+ $item->addIcon('none', pht('Not Signable'));
} else {
- $item->addAttribute(
- array(
- id(new PHUIIconView())->setIconFont('fa-square-o', 'grey'),
- ' ',
- pht('Not Signed'),
- ));
+
+ $type_name = $document->getSignatureTypeName();
+ $type_icon = $document->getSignatureTypeIcon();
+ $item->addIcon($type_icon, $type_name);
+
+ if ($viewer->getPHID()) {
+ $signature = $document->getUserSignature($viewer->getPHID());
+ } else {
+ $signature = null;
+ }
+
+ if ($signature) {
+ $item->addAttribute(
+ array(
+ id(new PHUIIconView())->setIconFont('fa-check-square-o', 'green'),
+ ' ',
+ pht(
+ 'Signed on %s',
+ phabricator_date($signature->getDateCreated(), $viewer)),
+ ));
+ } else {
+ $item->addAttribute(
+ array(
+ id(new PHUIIconView())->setIconFont('fa-square-o', 'grey'),
+ ' ',
+ pht('Not Signed'),
+ ));
+ }
}
+ $item->addIcon(
+ 'fa-pencil grey',
+ pht('Version %d (%s)', $document->getVersions(), $last_updated));
+
$list->addItem($item);
}

File Metadata

Mime Type
text/plain
Expires
Tue, Mar 18, 1:51 AM (4 d, 10 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7704078
Default Alt Text
D11834.diff (2 KB)

Event Timeline