Page MenuHomePhabricator

Make legalpad document list a little nicer for unsignable documents
ClosedPublic

Authored by epriestley on Feb 20 2015, 3:24 PM.
Tags
None
Referenced Files
F10769770: D11834.diff
Sat, May 28, 12:07 AM
Unknown Object (File)
Fri, May 27, 12:14 AM
Unknown Object (File)
Thu, May 26, 7:00 PM
Unknown Object (File)
Thu, May 26, 10:22 AM
Unknown Object (File)
Thu, May 26, 10:22 AM
Unknown Object (File)
Apr 14 2017, 10:38 AM
Unknown Object (File)
Nov 23 2016, 3:44 AM
Unknown Object (File)
Nov 19 2016, 4:18 PM
Subscribers

Details

Summary

This just cleans things up a little:

  • Don't show signature status if the document isn't signable.
  • Show "Not Signable" instead of "No One" to make the meaning more clear in this context, where we don't have a "Who should sign:" sort of cue.
Test Plan

Screen_Shot_2015-02-20_at_7.22.22_AM.png (201×1 px, 29 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make legalpad document list a little nicer for unsignable documents.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 20 2015, 3:26 PM
This revision was automatically updated to reflect the committed changes.