Files F15397272

D17508.diff
No OneTemporary
Actions

Size

853 B

Referenced Files

None

Subscribers

None

D17508.diff
View Options

	diff --git a/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php b/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
	--- a/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
	+++ b/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
	@@ -392,8 +392,11 @@
	private function loadGitRemoteRefs(PhabricatorRepository $repository) {
	$remote_envelope = $repository->getRemoteURIEnvelope();

	+ // NOTE: "git ls-remote" does not support "--" until circa January 2016.
	+ // See T12416. None of the flags to "ls-remote" appear dangerous, and
	+ // other checks make it difficult to configure a suspicious remote URI.
	list($stdout) = $repository->execxRemoteCommand(
	- 'ls-remote -- %P',
	+ 'ls-remote %P',
	$remote_envelope);

	$map = array();

File Metadata

Mime Type: text/plain
Expires: Mar 17 2025, 7:16 PM (4 w, 2 d ago)
Storage Engine: blob
Storage Format: Encrypted (AES-256-CBC)
Storage Handle: 7453782
Default Alt Text: D17508.diff (853 B)

Event Timeline