Page MenuHomePhabricator
Files F15394960

D15182.diff
No OneTemporary
Actions

D15182.diff
View Options

diff --git a/src/applications/people/controller/PhabricatorPeopleProfileViewController.php b/src/applications/people/controller/PhabricatorPeopleProfileViewController.php
--- a/src/applications/people/controller/PhabricatorPeopleProfileViewController.php
+++ b/src/applications/people/controller/PhabricatorPeopleProfileViewController.php
@@ -176,39 +176,40 @@
return $box;
}
- private function buildBadgesView(
- PhabricatorUser $user) {
+ private function buildBadgesView(PhabricatorUser $user) {
$viewer = $this->getViewer();
$class = 'PhabricatorBadgesApplication';
- if (PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) {
- $badge_phids = $user->getBadgePHIDs();
- if ($badge_phids) {
- $badges = id(new PhabricatorBadgesQuery())
- ->setViewer($viewer)
- ->withPHIDs($badge_phids)
- ->withStatuses(array(PhabricatorBadgesBadge::STATUS_ACTIVE))
- ->execute();
-
- $flex = new PHUIBadgeBoxView();
- foreach ($badges as $badge) {
- $item = id(new PHUIBadgeView())
- ->setIcon($badge->getIcon())
- ->setHeader($badge->getName())
- ->setSubhead($badge->getFlavor())
- ->setQuality($badge->getQuality());
- $flex->addItem($item);
- }
-
- } else {
- $error = id(new PHUIBoxView())
- ->addClass('mlb')
- ->appendChild(pht('User does not have any badges.'));
- $flex = id(new PHUIInfoView())
- ->setSeverity(PHUIInfoView::SEVERITY_NODATA)
- ->appendChild($error);
+ if (!PhabricatorApplication::isClassInstalledForViewer($class, $viewer)) {
+ return null;
+ }
+
+ $badge_phids = $user->getBadgePHIDs();
+ if ($badge_phids) {
+ $badges = id(new PhabricatorBadgesQuery())
+ ->setViewer($viewer)
+ ->withPHIDs($badge_phids)
+ ->withStatuses(array(PhabricatorBadgesBadge::STATUS_ACTIVE))
+ ->execute();
+
+ $flex = new PHUIBadgeBoxView();
+ foreach ($badges as $badge) {
+ $item = id(new PHUIBadgeView())
+ ->setIcon($badge->getIcon())
+ ->setHeader($badge->getName())
+ ->setSubhead($badge->getFlavor())
+ ->setQuality($badge->getQuality());
+ $flex->addItem($item);
}
+
+ } else {
+ $error = id(new PHUIBoxView())
+ ->addClass('mlb')
+ ->appendChild(pht('User does not have any badges.'));
+ $flex = id(new PHUIInfoView())
+ ->setSeverity(PHUIInfoView::SEVERITY_NODATA)
+ ->appendChild($error);
}
$box = id(new PHUIObjectBoxView())

File Metadata

Mime Type
text/plain
Expires
Mon, Mar 17, 2:33 AM (2 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7384172
Default Alt Text
D15182.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility