Page MenuHomePhabricator
Files F15393983

D19013.id45582.diff
No OneTemporary
Actions

D19013.id45582.diff
View Options

diff --git a/resources/sql/autopatches/20180207.mail.01.task.sql b/resources/sql/autopatches/20180207.mail.01.task.sql
new file mode 100644
--- /dev/null
+++ b/resources/sql/autopatches/20180207.mail.01.task.sql
@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_maniphest.maniphest_task
+ DROP originalTitle;
diff --git a/resources/sql/autopatches/20180207.mail.02.revision.sql b/resources/sql/autopatches/20180207.mail.02.revision.sql
new file mode 100644
--- /dev/null
+++ b/resources/sql/autopatches/20180207.mail.02.revision.sql
@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_differential.differential_revision
+ DROP originalTitle;
diff --git a/resources/sql/autopatches/20180207.mail.03.mock.sql b/resources/sql/autopatches/20180207.mail.03.mock.sql
new file mode 100644
--- /dev/null
+++ b/resources/sql/autopatches/20180207.mail.03.mock.sql
@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_pholio.pholio_mock
+ DROP originalName;
diff --git a/src/applications/differential/storage/DifferentialRevision.php b/src/applications/differential/storage/DifferentialRevision.php
--- a/src/applications/differential/storage/DifferentialRevision.php
+++ b/src/applications/differential/storage/DifferentialRevision.php
@@ -20,7 +20,6 @@
PhabricatorDraftInterface {
protected $title = '';
- protected $originalTitle;
protected $status;
protected $summary = '';
@@ -98,7 +97,6 @@
),
self::CONFIG_COLUMN_SCHEMA => array(
'title' => 'text255',
- 'originalTitle' => 'text255',
'status' => 'text32',
'summary' => 'text',
'testPlan' => 'text',
@@ -155,14 +153,6 @@
return '/'.$this->getMonogram();
}
- public function setTitle($title) {
- $this->title = $title;
- if (!$this->getID()) {
- $this->originalTitle = $title;
- }
- return $this;
- }
-
public function loadIDsByCommitPHIDs($phids) {
if (!$phids) {
return array();
diff --git a/src/applications/maniphest/editor/ManiphestTransactionEditor.php b/src/applications/maniphest/editor/ManiphestTransactionEditor.php
--- a/src/applications/maniphest/editor/ManiphestTransactionEditor.php
+++ b/src/applications/maniphest/editor/ManiphestTransactionEditor.php
@@ -522,7 +522,6 @@
'status' => '""',
'priority' => 0,
'title' => '""',
- 'originalTitle' => '""',
'description' => '""',
'dateCreated' => 0,
'dateModified' => 0,
diff --git a/src/applications/maniphest/storage/ManiphestTask.php b/src/applications/maniphest/storage/ManiphestTask.php
--- a/src/applications/maniphest/storage/ManiphestTask.php
+++ b/src/applications/maniphest/storage/ManiphestTask.php
@@ -31,7 +31,6 @@
protected $subpriority = 0;
protected $title = '';
- protected $originalTitle = '';
protected $description = '';
protected $originalEmailSource;
protected $mailKey;
@@ -83,7 +82,6 @@
'status' => 'text64',
'priority' => 'uint32',
'title' => 'sort',
- 'originalTitle' => 'text',
'description' => 'text',
'mailKey' => 'bytes20',
'ownerOrdering' => 'text64?',
@@ -176,14 +174,6 @@
return $this;
}
- public function setTitle($title) {
- $this->title = $title;
- if (!$this->getID()) {
- $this->originalTitle = $title;
- }
- return $this;
- }
-
public function getMonogram() {
return 'T'.$this->getID();
}
diff --git a/src/applications/pholio/storage/PholioMock.php b/src/applications/pholio/storage/PholioMock.php
--- a/src/applications/pholio/storage/PholioMock.php
+++ b/src/applications/pholio/storage/PholioMock.php
@@ -25,7 +25,6 @@
protected $editPolicy;
protected $name;
- protected $originalName;
protected $description;
protected $coverPHID;
protected $mailKey;
@@ -65,7 +64,6 @@
self::CONFIG_COLUMN_SCHEMA => array(
'name' => 'text128',
'description' => 'text',
- 'originalName' => 'text128',
'mailKey' => 'bytes20',
'status' => 'text12',
),
diff --git a/src/applications/pholio/xaction/PholioMockNameTransaction.php b/src/applications/pholio/xaction/PholioMockNameTransaction.php
--- a/src/applications/pholio/xaction/PholioMockNameTransaction.php
+++ b/src/applications/pholio/xaction/PholioMockNameTransaction.php
@@ -15,9 +15,6 @@
public function applyInternalEffects($object, $value) {
$object->setName($value);
- if ($object->getOriginalName() === null) {
- $object->setOriginalName($this->getNewValue());
- }
}
public function getTitle() {
diff --git a/src/applications/ponder/storage/PonderQuestion.php b/src/applications/ponder/storage/PonderQuestion.php
--- a/src/applications/ponder/storage/PonderQuestion.php
+++ b/src/applications/ponder/storage/PonderQuestion.php
@@ -194,11 +194,6 @@
return parent::save();
}
- public function getOriginalTitle() {
- // TODO: Make this actually save/return the original title.
- return $this->getTitle();
- }
-
public function getFullTitle() {
$id = $this->getID();
$title = $this->getTitle();

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 16, 11:18 PM (3 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7332596
Default Alt Text
D19013.id45582.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility