D8526.id20230.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D8526.id20230.diff
View Options

	diff --git a/src/applications/differential/customfield/DifferentialRevisionIDField.php b/src/applications/differential/customfield/DifferentialRevisionIDField.php
	--- a/src/applications/differential/customfield/DifferentialRevisionIDField.php
	+++ b/src/applications/differential/customfield/DifferentialRevisionIDField.php
	@@ -3,6 +3,8 @@
	final class DifferentialRevisionIDField
	extends DifferentialCustomField {

	+ private $revisionID;
	+
	public function getFieldKey() {
	return 'differential:revision-id';
	}
	@@ -29,16 +31,20 @@
	return true;
	}

	- public function shouldAllowEditInCommitMessage() {
	- return false;
	- }
	-
	public function parseValueFromCommitMessage($value) {
	return self::parseRevisionIDFromURI($value);
	}

	public function renderCommitMessageValue(array $handles) {
	- return PhabricatorEnv::getProductionURI('/D'.$this->getObject()->getID());
	+ $id = coalesce($this->revisionID, $this->getObject()->getID());
	+ if (!$id) {
	+ return null;
	+ }
	+ return PhabricatorEnv::getProductionURI('/D'.$id);
	+ }
	+
	+ public function readValueFromCommitMessage($value) {
	+ $this->revisionID = $value;
	}

	private static function parseRevisionIDFromURI($uri) {