Page MenuHomePhabricator

Fix "arc diff --verbatim" when updating a revision
ClosedPublic

Authored by epriestley on Mar 14 2014, 1:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 16, 6:46 PM
Unknown Object (File)
Mon, May 26, 5:59 AM
Unknown Object (File)
May 7 2025, 8:38 AM
Unknown Object (File)
Apr 30 2025, 11:52 AM
Unknown Object (File)
Apr 22 2025, 5:17 PM
Unknown Object (File)
Apr 21 2025, 8:20 PM
Unknown Object (File)
Apr 21 2025, 1:44 PM
Unknown Object (File)
Apr 21 2025, 1:16 AM
Subscribers

Details

Summary

Fixes T4601. The "Differential Revision" field needs to be present in the "editable" version of the message so that --verbatim works correctly. Some day all of this might get rewritten to be a little easier to follow, maybe, but keep things working properly for now.

Test Plan

Used arc diff, arc diff --edit, arc diff --verbatim

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix "arc diff --verbatim" when updating a revision.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2014, 5:33 PM
epriestley updated this revision to Diff 20251.

Closed by commit rPab117c2baf34 (authored by @epriestley).