Page MenuHomePhabricator

Fix "arc diff --verbatim" when updating a revision
ClosedPublic

Authored by epriestley on Mar 14 2014, 1:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 16, 1:49 AM
Unknown Object (File)
Mon, Jan 6, 4:54 AM
Unknown Object (File)
Dec 5 2024, 4:51 PM
Unknown Object (File)
Nov 27 2024, 12:24 PM
Unknown Object (File)
Nov 26 2024, 4:28 PM
Unknown Object (File)
Nov 26 2024, 4:28 PM
Unknown Object (File)
Nov 26 2024, 4:28 PM
Unknown Object (File)
Nov 24 2024, 11:33 AM
Subscribers

Details

Summary

Fixes T4601. The "Differential Revision" field needs to be present in the "editable" version of the message so that --verbatim works correctly. Some day all of this might get rewritten to be a little easier to follow, maybe, but keep things working properly for now.

Test Plan

Used arc diff, arc diff --edit, arc diff --verbatim

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix "arc diff --verbatim" when updating a revision.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2014, 5:33 PM
epriestley updated this revision to Diff 20251.

Closed by commit rPab117c2baf34 (authored by @epriestley).