Page MenuHomePhabricator

Fix "arc diff --verbatim" when updating a revision
ClosedPublic

Authored by epriestley on Mar 14 2014, 1:18 AM.
Tags
None
Referenced Files
F15396651: D8526.id20251.diff
Sun, Mar 16, 3:38 PM
F15393110: D8526.id20230.diff
Sat, Mar 15, 7:44 PM
F15367383: D8526.diff
Tue, Mar 11, 6:09 PM
F15282634: D8526.id20230.diff
Tue, Mar 4, 12:52 AM
Unknown Object (File)
Feb 22 2025, 9:53 PM
Unknown Object (File)
Feb 14 2025, 10:56 PM
Unknown Object (File)
Feb 14 2025, 10:56 PM
Unknown Object (File)
Feb 14 2025, 10:56 PM
Subscribers

Details

Summary

Fixes T4601. The "Differential Revision" field needs to be present in the "editable" version of the message so that --verbatim works correctly. Some day all of this might get rewritten to be a little easier to follow, maybe, but keep things working properly for now.

Test Plan

Used arc diff, arc diff --edit, arc diff --verbatim

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix "arc diff --verbatim" when updating a revision.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2014, 5:33 PM
epriestley updated this revision to Diff 20251.

Closed by commit rPab117c2baf34 (authored by @epriestley).