Page MenuHomePhabricator

D21225.id50550.diff
No OneTemporary

D21225.id50550.diff

diff --git a/src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php
--- a/src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php
+++ b/src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php
@@ -94,17 +94,8 @@
->setContent($content));
}
- if ($request->getValue('attach_inlines')) {
- $type_inline = DifferentialTransaction::TYPE_INLINE;
- $inlines = DifferentialTransactionQuery::loadUnsubmittedInlineComments(
- $viewer,
- $revision);
- foreach ($inlines as $inline) {
- $xactions[] = id(new DifferentialTransaction())
- ->setTransactionType($type_inline)
- ->attachComment($inline);
- }
- }
+ // NOTE: The legacy "attach_inlines" flag is now ignored and has no
+ // effect. See T13513.
// NOTE: The legacy "silent" flag is now ignored and has no effect. See
// T13042.

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 16, 5:48 PM (2 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7381885
Default Alt Text
D21225.id50550.diff (1 KB)

Event Timeline