Page MenuHomePhabricator
Files F15392358

D17877.id43003.diff
No OneTemporary
Actions

D17877.id43003.diff
View Options

diff --git a/src/applications/meta/controller/PhabricatorApplicationEditController.php b/src/applications/meta/controller/PhabricatorApplicationEditController.php
--- a/src/applications/meta/controller/PhabricatorApplicationEditController.php
+++ b/src/applications/meta/controller/PhabricatorApplicationEditController.php
@@ -32,7 +32,6 @@
if ($request->isFormPost()) {
$xactions = array();
- $result = array();
$template = $application->getApplicationTransactionTemplate();
foreach ($application->getCapabilities() as $capability) {
if (!$application->isCapabilityEditable($capability)) {
@@ -47,8 +46,6 @@
continue;
}
- $result[$capability] = $new;
-
$xactions[] = id(clone $template)
->setTransactionType(
PhabricatorApplicationPolicyChangeTransaction::TRANSACTIONTYPE)
@@ -58,25 +55,23 @@
->setNewValue($new);
}
- if ($result) {
- $editor = id(new PhabricatorApplicationEditor())
- ->setActor($user)
- ->setContentSourceFromRequest($request)
- ->setContinueOnNoEffect(true)
- ->setContinueOnMissingFields(true);
-
- try {
- $editor->applyTransactions($application, $xactions);
- return id(new AphrontRedirectResponse())->setURI($view_uri);
- } catch (PhabricatorApplicationTransactionValidationException $ex) {
- $validation_exception = $ex;
- }
-
- return $this->newDialog()
- ->setTitle('Validation Failed')
- ->setValidationException($validation_exception)
- ->addCancelButton($view_uri);
+ $editor = id(new PhabricatorApplicationEditor())
+ ->setActor($user)
+ ->setContentSourceFromRequest($request)
+ ->setContinueOnNoEffect(true)
+ ->setContinueOnMissingFields(true);
+
+ try {
+ $editor->applyTransactions($application, $xactions);
+ return id(new AphrontRedirectResponse())->setURI($view_uri);
+ } catch (PhabricatorApplicationTransactionValidationException $ex) {
+ $validation_exception = $ex;
}
+
+ return $this->newDialog()
+ ->setTitle(pht('Validation Failed'))
+ ->setValidationException($validation_exception)
+ ->addCancelButton($view_uri);
}
$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 16, 2:45 PM (6 d, 15 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7707227
Default Alt Text
D17877.id43003.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility