Page MenuHomePhabricator
Files F15391780

D11321.id27192.diff
No OneTemporary
Actions

D11321.id27192.diff
View Options

diff --git a/src/lint/linter/ArcanistCpplintLinter.php b/src/lint/linter/ArcanistCpplintLinter.php
--- a/src/lint/linter/ArcanistCpplintLinter.php
+++ b/src/lint/linter/ArcanistCpplintLinter.php
@@ -70,10 +70,6 @@
$messages[] = $message;
}
- if ($err && !$messages) {
- return false;
- }
-
return $messages;
}
diff --git a/src/lint/linter/ArcanistExternalLinter.php b/src/lint/linter/ArcanistExternalLinter.php
--- a/src/lint/linter/ArcanistExternalLinter.php
+++ b/src/lint/linter/ArcanistExternalLinter.php
@@ -413,6 +413,13 @@
$messages = $this->parseLinterOutput($path, $err, $stdout, $stderr);
+ if ($err && $this->shouldExpectCommandErrors() && !$messages) {
+ // We assume that if the future exits with a non-zero status and we
+ // failed to parse any linter messages, then something must've gone wrong
+ // during parsing.
+ $messages = false;
+ }
+
if ($messages === false) {
if ($err) {
$future->resolvex();
diff --git a/src/lint/linter/ArcanistFlake8Linter.php b/src/lint/linter/ArcanistFlake8Linter.php
--- a/src/lint/linter/ArcanistFlake8Linter.php
+++ b/src/lint/linter/ArcanistFlake8Linter.php
@@ -92,10 +92,6 @@
$messages[] = $message;
}
- if ($err && !$messages) {
- return false;
- }
-
return $messages;
}
diff --git a/src/lint/linter/ArcanistJSONLintLinter.php b/src/lint/linter/ArcanistJSONLintLinter.php
--- a/src/lint/linter/ArcanistJSONLintLinter.php
+++ b/src/lint/linter/ArcanistJSONLintLinter.php
@@ -87,10 +87,6 @@
}
}
- if ($err && !$messages) {
- return false;
- }
-
return $messages;
}
diff --git a/src/lint/linter/ArcanistJscsLinter.php b/src/lint/linter/ArcanistJscsLinter.php
--- a/src/lint/linter/ArcanistJscsLinter.php
+++ b/src/lint/linter/ArcanistJscsLinter.php
@@ -131,10 +131,6 @@
}
}
- if ($err && !$messages) {
- return false;
- }
-
return $messages;
}
diff --git a/src/lint/linter/ArcanistLesscLinter.php b/src/lint/linter/ArcanistLesscLinter.php
--- a/src/lint/linter/ArcanistLesscLinter.php
+++ b/src/lint/linter/ArcanistLesscLinter.php
@@ -189,10 +189,6 @@
}
}
- if ($err && !$messages) {
- return false;
- }
-
return $messages;
}
diff --git a/src/lint/linter/ArcanistPEP8Linter.php b/src/lint/linter/ArcanistPEP8Linter.php
--- a/src/lint/linter/ArcanistPEP8Linter.php
+++ b/src/lint/linter/ArcanistPEP8Linter.php
@@ -98,10 +98,6 @@
$messages[] = $message;
}
- if ($err && !$messages) {
- return false;
- }
-
return $messages;
}
diff --git a/src/lint/linter/ArcanistPuppetLintLinter.php b/src/lint/linter/ArcanistPuppetLintLinter.php
--- a/src/lint/linter/ArcanistPuppetLintLinter.php
+++ b/src/lint/linter/ArcanistPuppetLintLinter.php
@@ -132,10 +132,6 @@
}
}
- if ($err && !$messages) {
- return false;
- }
-
return $messages;
}
diff --git a/src/lint/linter/ArcanistPyFlakesLinter.php b/src/lint/linter/ArcanistPyFlakesLinter.php
--- a/src/lint/linter/ArcanistPyFlakesLinter.php
+++ b/src/lint/linter/ArcanistPyFlakesLinter.php
@@ -92,10 +92,6 @@
$messages[] = $message;
}
- if ($err && !$messages) {
- return false;
- }
-
return $messages;
}
diff --git a/src/lint/linter/ArcanistRubyLinter.php b/src/lint/linter/ArcanistRubyLinter.php
--- a/src/lint/linter/ArcanistRubyLinter.php
+++ b/src/lint/linter/ArcanistRubyLinter.php
@@ -92,10 +92,6 @@
$messages[] = $message;
}
- if ($err && !$messages) {
- return false;
- }
-
return $messages;
}

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 16, 11:35 AM (2 d, 3 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7706945
Default Alt Text
D11321.id27192.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility