Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15386442
D18233.id43865.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
788 B
Referenced Files
None
Subscribers
None
D18233.id43865.diff
View Options
diff --git a/src/applications/conduit/controller/PhabricatorConduitAPIController.php b/src/applications/conduit/controller/PhabricatorConduitAPIController.php
--- a/src/applications/conduit/controller/PhabricatorConduitAPIController.php
+++ b/src/applications/conduit/controller/PhabricatorConduitAPIController.php
@@ -119,9 +119,11 @@
->setError((string)$error_code)
->setDuration(1000000 * ($time_end - $time_start));
- $unguarded = AphrontWriteGuard::beginScopedUnguardedWrites();
- $log->save();
- unset($unguarded);
+ if (!PhabricatorEnv::isReadOnly()) {
+ $unguarded = AphrontWriteGuard::beginScopedUnguardedWrites();
+ $log->save();
+ unset($unguarded);
+ }
$response = id(new ConduitAPIResponse())
->setResult($result)
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Mar 16, 12:35 AM (1 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7390699
Default Alt Text
D18233.id43865.diff (788 B)
Attached To
Mode
D18233: Skip Conduit call log writes in read-only mode, allowing "conduit.ping" to run
Attached
Detach File
Event Timeline
Log In to Comment