Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15385242
D11834.id28522.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D11834.id28522.diff
View Options
diff --git a/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php b/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php
--- a/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php
+++ b/src/applications/legalpad/query/LegalpadDocumentSearchEngine.php
@@ -168,43 +168,50 @@
$title = $document->getTitle();
- $type_name = $document->getSignatureTypeName();
- $type_icon = $document->getSignatureTypeIcon();
-
$item = id(new PHUIObjectItemView())
->setObjectName($document->getMonogram())
->setHeader($title)
->setHref('/'.$document->getMonogram())
- ->setObject($document)
- ->addIcon($type_icon, $type_name)
- ->addIcon(
- 'fa-pencil grey',
- pht('Version %d (%s)', $document->getVersions(), $last_updated));
-
- if ($viewer->getPHID()) {
- $signature = $document->getUserSignature($viewer->getPHID());
- } else {
- $signature = null;
- }
+ ->setObject($document);
- if ($signature) {
- $item->addAttribute(
- array(
- id(new PHUIIconView())->setIconFont('fa-check-square-o', 'green'),
- ' ',
- pht(
- 'Signed on %s',
- phabricator_date($signature->getDateCreated(), $viewer)),
- ));
+ $no_signatures = LegalpadDocument::SIGNATURE_TYPE_NONE;
+ if ($document->getSignatureType() == $no_signatures) {
+ $item->addIcon('none', pht('Not Signable'));
} else {
- $item->addAttribute(
- array(
- id(new PHUIIconView())->setIconFont('fa-square-o', 'grey'),
- ' ',
- pht('Not Signed'),
- ));
+
+ $type_name = $document->getSignatureTypeName();
+ $type_icon = $document->getSignatureTypeIcon();
+ $item->addIcon($type_icon, $type_name);
+
+ if ($viewer->getPHID()) {
+ $signature = $document->getUserSignature($viewer->getPHID());
+ } else {
+ $signature = null;
+ }
+
+ if ($signature) {
+ $item->addAttribute(
+ array(
+ id(new PHUIIconView())->setIconFont('fa-check-square-o', 'green'),
+ ' ',
+ pht(
+ 'Signed on %s',
+ phabricator_date($signature->getDateCreated(), $viewer)),
+ ));
+ } else {
+ $item->addAttribute(
+ array(
+ id(new PHUIIconView())->setIconFont('fa-square-o', 'grey'),
+ ' ',
+ pht('Not Signed'),
+ ));
+ }
}
+ $item->addIcon(
+ 'fa-pencil grey',
+ pht('Version %d (%s)', $document->getVersions(), $last_updated));
+
$list->addItem($item);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Mar 15, 10:03 PM (6 d, 16 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7704078
Default Alt Text
D11834.id28522.diff (2 KB)
Attached To
Mode
D11834: Make legalpad document list a little nicer for unsignable documents
Attached
Detach File
Event Timeline
Log In to Comment