Page MenuHomePhabricator

D11844.id.diff
No OneTemporary

D11844.id.diff

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -122,7 +122,7 @@
'rsrc/css/phui/calendar/phui-calendar.css' => '8675968e',
'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
'rsrc/css/phui/phui-action-list.css' => '9ee9910a',
- 'rsrc/css/phui/phui-action-panel.css' => 'd2e088bd',
+ 'rsrc/css/phui/phui-action-panel.css' => '3ee9afd5',
'rsrc/css/phui/phui-box.css' => '7b3a2eed',
'rsrc/css/phui/phui-button.css' => 'ffe12633',
'rsrc/css/phui/phui-crumbs-view.css' => '594d719e',
@@ -771,7 +771,7 @@
'phrequent-css' => 'ffc185ad',
'phriction-document-css' => '7d7f0071',
'phui-action-header-view-css' => '89c497e7',
- 'phui-action-panel-css' => 'd2e088bd',
+ 'phui-action-panel-css' => '3ee9afd5',
'phui-box-css' => '7b3a2eed',
'phui-button-css' => 'ffe12633',
'phui-calendar-css' => '8675968e',
diff --git a/src/view/phui/PHUIActionPanelView.php b/src/view/phui/PHUIActionPanelView.php
--- a/src/view/phui/PHUIActionPanelView.php
+++ b/src/view/phui/PHUIActionPanelView.php
@@ -82,8 +82,8 @@
$classes = array();
$classes[] = 'phui-action-panel';
- if ($this->state) {
- $classes[] = 'phui-action-panel-has-state';
+ if ($this->status) {
+ $classes[] = 'phui-action-panel-has-status';
$classes[] = $this->state;
}
@@ -158,9 +158,10 @@
if ($this->status && $this->state) {
$state_icon = $this->getStateIcon();
$status = phutil_tag(
- 'div',
+ ($this->href) ? 'a' : 'div',
array(
'class' => 'phui-action-panel-status',
+ 'href' => ($this->href) ? $this->href : null,
),
array($state_icon, $this->status));
}
diff --git a/webroot/rsrc/css/phui/phui-action-panel.css b/webroot/rsrc/css/phui/phui-action-panel.css
--- a/webroot/rsrc/css/phui/phui-action-panel.css
+++ b/webroot/rsrc/css/phui/phui-action-panel.css
@@ -6,7 +6,7 @@
position: relative;
}
-.phui-action-panel-has-state.phui-action-panel {
+.phui-action-panel-has-status.phui-action-panel {
padding-bottom: 44px;
}
@@ -66,6 +66,10 @@
right: 0;
}
+.phui-action-panel-status:hover {
+ text-decoration: none;
+}
+
.phui-action-panel-none .phui-action-panel-status {
background-color: {$lightgreybackground};
border-left: 4px solid {$greyborder};

File Metadata

Mime Type
text/plain
Expires
Sat, Mar 15, 9:00 PM (1 w, 16 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7703650
Default Alt Text
D11844.id.diff (2 KB)

Event Timeline