Page MenuHomePhabricator
Differential D11844

Correct logic in PHUIActionPanelView
ClosedPublic
Actions

Authored by chad on Feb 21 2015, 4:42 AM.
Tags
None
Referenced Files
F13084446: D11844.diff
Wed, Apr 24, 11:01 PM
Unknown Object (File)
Sat, Apr 20, 1:18 AM
Unknown Object (File)
Wed, Apr 17, 8:26 PM
Unknown Object (File)
Wed, Apr 17, 8:26 PM
Unknown Object (File)
Wed, Apr 17, 8:26 PM
Unknown Object (File)
Wed, Apr 17, 8:21 PM
Unknown Object (File)
Wed, Apr 17, 8:00 PM
Unknown Object (File)
Tue, Apr 16, 10:44 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP1d5825c695f4: Correct logic in PHUIActionPanelView
Summary

We should only be adding space then a status is set, not a state.

Test Plan

Test on UIExamples, still renders as expected.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 28543.Feb 21 2015, 4:42 AM
chad retitled this revision from to Correct logic in PHUIActionPanelView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 21 2015, 4:42 AM
chad updated this revision to Diff 28544.Feb 21 2015, 4:53 AM
  • also make status clickable
epriestley accepted this revision.Feb 21 2015, 10:32 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 21 2015, 10:32 AM
Closed by commit rP1d5825c695f4: Correct logic in PHUIActionPanelView (authored by chad, committed by chad). · Explain WhyFeb 21 2015, 2:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
view/
phui/
7 lines
webroot/
rsrc/
css/
phui/
6 lines

Diff 28548

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIActionPanelView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-action-panel.css

Loading...
Phabricator · Built by Phacility