Page MenuHomePhabricator
Files F15382872

D20461.id48835.diff
No OneTemporary
Actions

D20461.id48835.diff
View Options

diff --git a/src/applications/differential/storage/DifferentialRevision.php b/src/applications/differential/storage/DifferentialRevision.php
--- a/src/applications/differential/storage/DifferentialRevision.php
+++ b/src/applications/differential/storage/DifferentialRevision.php
@@ -53,8 +53,6 @@
private $flags = array();
private $forceMap = array();
- const TABLE_COMMIT = 'differential_commit';
-
const RELATION_REVIEWER = 'revw';
const RELATION_SUBSCRIBED = 'subd';
@@ -1021,12 +1019,6 @@
$conn_w = $this->establishConnection('w');
- queryfx(
- $conn_w,
- 'DELETE FROM %T WHERE revisionID = %d',
- self::TABLE_COMMIT,
- $this->getID());
-
// we have to do paths a little differently as they do not have
// an id or phid column for delete() to act on
$dummy_path = new DifferentialAffectedPath();
diff --git a/src/applications/differential/storage/DifferentialSchemaSpec.php b/src/applications/differential/storage/DifferentialSchemaSpec.php
--- a/src/applications/differential/storage/DifferentialSchemaSpec.php
+++ b/src/applications/differential/storage/DifferentialSchemaSpec.php
@@ -26,9 +26,12 @@
'persistence' => PhabricatorConfigTableSchema::PERSISTENCE_CACHE,
));
+ // TODO: All readers and writers for this table were removed in April
+ // 2019. Destroy this table once we're sure we won't miss it.
+
$this->buildRawSchema(
id(new DifferentialRevision())->getApplicationName(),
- DifferentialRevision::TABLE_COMMIT,
+ 'differential_commit',
array(
'revisionID' => 'id',
'commitPHID' => 'phid',
diff --git a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
--- a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
+++ b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
@@ -231,13 +231,6 @@
->addEdge($commit->getPHID(), $commit_drev, $revision->getPHID())
->save();
- queryfx(
- $conn_w,
- 'INSERT IGNORE INTO %T (revisionID, commitPHID) VALUES (%d, %s)',
- DifferentialRevision::TABLE_COMMIT,
- $revision->getID(),
- $commit->getPHID());
-
$should_close = !$revision->isPublished() && $should_autoclose;
if ($should_close) {
$type_close = DifferentialRevisionCloseTransaction::TRANSACTIONTYPE;

File Metadata

Mime Type
text/plain
Expires
Sat, Mar 15, 2:48 PM (1 w, 22 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7692455
Default Alt Text
D20461.id48835.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility