D14168.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D14168.diff
View Options

	diff --git a/src/applications/transactions/controller/PhabricatorApplicationTransactionDetailController.php b/src/applications/transactions/controller/PhabricatorApplicationTransactionDetailController.php
	--- a/src/applications/transactions/controller/PhabricatorApplicationTransactionDetailController.php
	+++ b/src/applications/transactions/controller/PhabricatorApplicationTransactionDetailController.php
	@@ -3,22 +3,16 @@
	final class PhabricatorApplicationTransactionDetailController
	extends PhabricatorApplicationTransactionController {

	- private $phid;
	-
	public function shouldAllowPublic() {
	return true;
	}

	- public function willProcessRequest(array $data) {
	- $this->phid = $data['phid'];
	- }
	-
	- public function processRequest() {
	- $request = $this->getRequest();
	- $viewer = $request->getUser();
	+ public function handleRequest(AphrontRequest $request) {
	+ $viewer = $this->getViewer();
	+ $phid = $request->getURIData('phid');

	$xaction = id(new PhabricatorObjectQuery())
	- ->withPHIDs(array($this->phid))
	+ ->withPHIDs(array($phid))
	->setViewer($viewer)
	->executeOne();
	if (!$xaction) {
	@@ -26,17 +20,14 @@
	}

	$details = $xaction->renderChangeDetails($viewer);
	-
	$cancel_uri = $this->guessCancelURI($viewer, $xaction);
	- $dialog = id(new AphrontDialogView())
	- ->setUser($viewer)
	+
	+ return $this->newDialog()
	->setTitle(pht('Change Details'))
	->setWidth(AphrontDialogView::WIDTH_FULL)
	->setFlush(true)
	->appendChild($details)
	->addCancelButton($cancel_uri);
	-
	- return id(new AphrontDialogResponse())->setDialog($dialog);
	}

	}