Differential D14168

Slightly modernize transaction diff controller
ClosedPublic
Actions

Authored by epriestley on Sep 25 2015, 5:29 PM.

Details

Reviewers

chad

Maniphest Tasks

T9272: Show x lines does not work as expected in dialog

Commits

Restricted Diffusion Commit
rP3e60740c7cbf: Slightly modernize transaction diff controller

Summary

Ref T9272. This doesn't fix anything, just a little cleanup while I was looking at it.

Test Plan

Clicked "Show Details" on a couple description changes, got the same effect for less code.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34225.Sep 25 2015, 5:29 PM

epriestley retitled this revision from to Slightly modernize transaction diff controller.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9272: Show x lines does not work as expected in dialog.

epriestley mentioned this in T9272: Show x lines does not work as expected in dialog.Sep 25 2015, 5:30 PM

chad accepted this revision.Sep 25 2015, 5:54 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 25 2015, 5:54 PM

Closed by commit rP3e60740c7cbf: Slightly modernize transaction diff controller (authored by epriestley, committed by epriestley). · Explain WhySep 25 2015, 6:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

controller/

PhabricatorApplicationTransactionDetailController.php

21 lines

Diff 34233

View Options

src/applications/transactions/controller/PhabricatorApplicationTransactionDetailController.php

Slightly modernize transaction diff controllerClosedPublicActions