Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15381108
D18175.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D18175.diff
View Options
diff --git a/src/applications/differential/field/DifferentialTestPlanCommitMessageField.php b/src/applications/differential/field/DifferentialTestPlanCommitMessageField.php
--- a/src/applications/differential/field/DifferentialTestPlanCommitMessageField.php
+++ b/src/applications/differential/field/DifferentialTestPlanCommitMessageField.php
@@ -50,11 +50,4 @@
);
}
- public function validateTransactions($object, array $xactions) {
- return $this->validateCommitMessageCorpusTransactions(
- $object,
- $xactions,
- pht('Test Plan'));
- }
-
}
diff --git a/src/applications/differential/xaction/DifferentialRevisionTestPlanTransaction.php b/src/applications/differential/xaction/DifferentialRevisionTestPlanTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionTestPlanTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionTestPlanTransaction.php
@@ -55,7 +55,10 @@
}
public function validateTransactions($object, array $xactions) {
- $errors = array();
+ $errors = $this->validateCommitMessageCorpusTransactions(
+ $object,
+ $xactions,
+ pht('Test Plan'));
$is_required = PhabricatorEnv::getEnvConfig(
'differential.require-test-plan-field');
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Mar 15, 5:55 AM (1 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7679291
Default Alt Text
D18175.diff (1 KB)
Attached To
Mode
D18175: Move misplaced validation for ambiguous fields in "Test Plan" to the right place
Attached
Detach File
Event Timeline
Log In to Comment