Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15380696
D19226.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D19226.diff
View Options
diff --git a/src/applications/subscriptions/policyrule/PhabricatorSubscriptionsSubscribersPolicyRule.php b/src/applications/subscriptions/policyrule/PhabricatorSubscriptionsSubscribersPolicyRule.php
--- a/src/applications/subscriptions/policyrule/PhabricatorSubscriptionsSubscribersPolicyRule.php
+++ b/src/applications/subscriptions/policyrule/PhabricatorSubscriptionsSubscribersPolicyRule.php
@@ -45,10 +45,13 @@
$this->subscribed[$viewer_phid] = array();
}
- // Load the project PHIDs the user is a member of.
+ // Load the project PHIDs the user is a member of. We use the omnipotent
+ // user here because projects may themselves have "Subscribers" visibility
+ // policies and we don't want to get stuck in an infinite stack of
+ // recursive policy checks. See T13106.
if (!isset($this->sourcePHIDs[$viewer_phid])) {
$projects = id(new PhabricatorProjectQuery())
- ->setViewer($viewer)
+ ->setViewer(PhabricatorUser::getOmnipotentUser())
->withMemberPHIDs(array($viewer_phid))
->execute();
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mar 15 2025, 4:09 AM (5 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7677318
Default Alt Text
D19226.diff (1 KB)
Attached To
Mode
D19226: When loading project membership to evaluate the "Subscribers" policy, use the ominipotent viewer
Attached
Detach File
Event Timeline
Log In to Comment