Page MenuHomePhabricator

D8246.diff
No OneTemporary

D8246.diff

Index: resources/celerity/map.php
===================================================================
--- resources/celerity/map.php
+++ resources/celerity/map.php
@@ -145,7 +145,7 @@
'rsrc/css/phui/phui-text.css' => '23e9b4b7',
'rsrc/css/phui/phui-timeline-view.css' => 'd3ccba00',
'rsrc/css/phui/phui-workboard-view.css' => 'bf70dd2e',
- 'rsrc/css/phui/phui-workpanel-view.css' => '6f8527f6',
+ 'rsrc/css/phui/phui-workpanel-view.css' => '97b69459',
'rsrc/css/sprite-actions.css' => '4557baf8',
'rsrc/css/sprite-apps-large.css' => '0a453d4b',
'rsrc/css/sprite-apps-xlarge.css' => 'db66c878',
@@ -757,7 +757,7 @@
'phui-text-css' => '23e9b4b7',
'phui-timeline-view-css' => 'd3ccba00',
'phui-workboard-view-css' => 'bf70dd2e',
- 'phui-workpanel-view-css' => '6f8527f6',
+ 'phui-workpanel-view-css' => '97b69459',
'policy-css' => '957ea14c',
'policy-edit-css' => '05cca26a',
'ponder-comment-table-css' => '6cdccea7',
Index: src/applications/project/controller/PhabricatorProjectBoardController.php
===================================================================
--- src/applications/project/controller/PhabricatorProjectBoardController.php
+++ src/applications/project/controller/PhabricatorProjectBoardController.php
@@ -4,6 +4,7 @@
extends PhabricatorProjectController {
private $id;
+ private $handles;
public function shouldAllowPublic() {
return true;
@@ -90,6 +91,8 @@
'moveURI' => $this->getApplicationURI('move/'.$project->getID().'/'),
));
+ $this->handles = ManiphestTaskListView::loadTaskHandles($viewer, $tasks);
+
foreach ($columns as $column) {
$panel = id(new PHUIWorkpanelView())
->setHeader($column->getDisplayName())
@@ -181,6 +184,7 @@
private function renderTaskCard(ManiphestTask $task) {
$request = $this->getRequest();
$viewer = $request->getUser();
+ $handles = $this->handles;
$color_map = ManiphestTaskPriority::getColorMap();
$bar_color = idx($color_map, $task->getPriority(), 'grey');
@@ -191,23 +195,30 @@
$task,
PhabricatorPolicyCapability::CAN_EDIT);
- return id(new PHUIObjectItemView())
- ->setObjectName('T'.$task->getID())
- ->setHeader($task->getTitle())
- ->setGrippable($can_edit)
- ->setHref('/T'.$task->getID())
- ->addSigil('project-card')
- ->setMetadata(
- array(
- 'objectPHID' => $task->getPHID(),
- ))
- ->addAction(
- id(new PHUIListItemView())
- ->setName(pht('Edit'))
- ->setIcon('edit')
- ->setHref('/maniphest/task/edit/'.$task->getID().'/')
- ->setWorkflow(true))
- ->setBarColor($bar_color);
+ $card = id(new PHUIObjectItemView())
+ ->setObjectName('T'.$task->getID())
+ ->setHeader($task->getTitle())
+ ->setGrippable($can_edit)
+ ->setHref('/T'.$task->getID())
+ ->addSigil('project-card')
+ ->setMetadata(
+ array(
+ 'objectPHID' => $task->getPHID(),
+ ))
+ ->addAction(
+ id(new PHUIListItemView())
+ ->setName(pht('Edit'))
+ ->setIcon('edit')
+ ->setHref('/maniphest/task/edit/'.$task->getID().'/')
+ ->setWorkflow(true))
+ ->setBarColor($bar_color);
+
+ if ($task->getOwnerPHID()) {
+ $owner = $handles[$task->getOwnerPHID()];
+ $card->addAttribute($owner->renderLink());
+ }
+
+ return $card;
}
}
Index: webroot/rsrc/css/phui/phui-workpanel-view.css
===================================================================
--- webroot/rsrc/css/phui/phui-workpanel-view.css
+++ webroot/rsrc/css/phui/phui-workpanel-view.css
@@ -79,3 +79,21 @@
.project-column-empty.drag-target-list {
background: rgba(255,255,255,.7);
}
+
+/* - Workpanel Cards -----------------------------------------------------------
+
+ Slight display changes for how cards work in tight spaces
+
+*/
+
+.phui-workpanel-view .phui-object-item-grippable .phui-object-item-frame {
+ padding-left: 0;
+}
+
+.phui-workpanel-view .phui-object-item-grip {
+ display: none;
+}
+
+.phui-workpanel-view .phui-object-item-attribute a {
+ color: {$bluetext};
+}

File Metadata

Mime Type
text/plain
Expires
Mar 14 2025, 5:05 PM (4 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7663138
Default Alt Text
D8246.diff (4 KB)

Event Timeline