Add owner to task boards, tidy UI
ClosedPublic
Actions

Authored by chad on Feb 15 2014, 8:47 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rP1c3373d77d9e: Add owner to task boards, tidy UI

Summary

Displays task owner, hides grip texture.

Test Plan

Visit a board in my sandbox, grab and move things.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

{F114142}

It's possible to have cards which you can't drag (since you can't edit the tasks) or a mixture of cards you can and can't drag, but the pencil icon can probably serve as a reasonable proxy for edit state without needing to drop the grip. I think both these cases are fairly rare. The JS doesn't currently distinguish between draggable and undraggable cards.

src/applications/project/controller/PhabricatorProjectBoardController.php
201	I think the grip is purely cosmetic, so a simpler fix might be to remove this line, rather than hiding it in CSS.

I went back and forth there, I either need to add the drag cursor or hide the grip, so I hid the grip since when that value is false, the cursor goes away.

Ah! That makes sense.

Closed by commit rP1c3373d77d9e (authored by @chad).

without needing to drop the grip

(I actually meant "without needing to also have the grip visible, which we selectively enable or disable", if that wasn't clear.)

No I am just more confused. :( If I messed it up, feel free to change it. :D

Haha, sorry. I just meant "when I looked at this change at first I had a concern, but I now realize that concern was silly, and this is a good change with no bad parts". My complete thought here is:

You might not have permission to drag some of the cards on the board, because you can't edit the tasks.
When I originally did the dragging stuff, I added the grip to distinguish between cards you can drag and cards you can't drag. My thinking was "draggable tasks have a grip, undraggable tasks don't", and that displaying the grip was important to communicate this information.
By removing the grip, we potentially lose information. This was my initial concern when I saw the screenshot.
However, I then quickly realized that the "edit" icon can convey the same information (draggability is always the same as task editability, at least for now), so we don't actually lose any information.
So the net effect is that this change is great: it looks much better and we don't lose any information (assuming users can figure out that this interface is draggable whatsoever, which I'm guessing they can).

There are some mooting factors right now:

Currently, we don't actually edit the task when you drag-and-drop it (we will after T4422).
So, you don't actually need edit permission to drag tasks around.
And we never stop you from dragging stuff around in the UI.

These make editability information much less important now than it will be in the future.