D20427.id48729.diff
No OneTemporary
Actions

Size

983 B

Referenced Files

None

Subscribers

None

D20427.id48729.diff
View Options

	diff --git a/src/applications/diffusion/herald/DiffusionCommitAutocloseHeraldField.php b/src/applications/diffusion/herald/DiffusionCommitAutocloseHeraldField.php
	--- a/src/applications/diffusion/herald/DiffusionCommitAutocloseHeraldField.php
	+++ b/src/applications/diffusion/herald/DiffusionCommitAutocloseHeraldField.php
	@@ -5,12 +5,18 @@

	const FIELDCONST = 'diffusion.commit.autoclose';

	+ public function getFieldGroupKey() {
	+ return HeraldDeprecatedFieldGroup::FIELDGROUPKEY;
	+ }
	+
	public function getHeraldFieldName() {
	- return pht('Commit is on permanent branch');
	+ // Herald no longer triggers until a commit is reachable from a permanent
	+ // ref, so this condition is always true by definition.
	+ return pht('Commit Autocloses (Deprecated)');
	}

	public function getHeraldFieldValue($object) {
	- return $object->getRepository()->shouldAutocloseCommit($object);
	+ return true;
	}

	public function getHeraldFieldConditions() {