Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15377254
D21853.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
749 B
Referenced Files
None
Subscribers
None
D21853.diff
View Options
diff --git a/src/unit/renderer/ArcanistUnitConsoleRenderer.php b/src/unit/renderer/ArcanistUnitConsoleRenderer.php
--- a/src/unit/renderer/ArcanistUnitConsoleRenderer.php
+++ b/src/unit/renderer/ArcanistUnitConsoleRenderer.php
@@ -12,7 +12,7 @@
$test_name = $result->getName();
$test_namespace = $result->getNamespace();
- if (strlen($test_namespace)) {
+ if (phutil_nonempty_string($test_namespace)) {
$test_name = $test_namespace.'::'.$test_name;
}
@@ -22,7 +22,7 @@
$test_name);
if ($result_code != ArcanistUnitTestResult::RESULT_PASS
- && strlen($result->getUserData())) {
+ && phutil_nonempty_string($result->getUserData())) {
$return .= $result->getUserData()."\n";
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Mar 14, 8:28 AM (1 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7409930
Default Alt Text
D21853.diff (749 B)
Attached To
Mode
D21853: Fix more PHP 8.1 "strlen(null)" callsites
Attached
Detach File
Event Timeline
Log In to Comment