Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15376045
D13542.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
883 B
Referenced Files
None
Subscribers
None
D13542.id.diff
View Options
diff --git a/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php b/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
--- a/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
+++ b/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
@@ -1763,6 +1763,16 @@
$viewer = $this->getViewer();
+ // If we have an omnipotent viewer and no formal space constraints, don't
+ // emit a clause. This primarily enables older migrations to run cleanly,
+ // without fataling because they try to match a `spacePHID` column which
+ // does not exist yet. See T8743, T8746.
+ if ($viewer->isOmnipotent()) {
+ if ($this->spaceIsArchived === null && $this->spacePHIDs === null) {
+ return null;
+ }
+ }
+
$space_phids = array();
$include_null = false;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Mar 14, 1:30 AM (4 w, 4 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7639910
Default Alt Text
D13542.id.diff (883 B)
Attached To
Mode
D13542: Don't apply space constraints to omnipotent-viewer queries
Attached
Detach File
Event Timeline
Log In to Comment