Page MenuHomePhabricator
Differential D13542

Don't apply space constraints to omnipotent-viewer queries
ClosedPublic
Actions

Authored by epriestley on Jul 3 2015, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 23 2025, 4:57 AM
Unknown Object (File)
May 9 2025, 6:52 PM
Unknown Object (File)
May 6 2025, 6:03 PM
Unknown Object (File)
Apr 24 2025, 5:24 AM
Unknown Object (File)
Apr 14 2025, 7:03 PM
Unknown Object (File)
Apr 14 2025, 7:21 AM
Unknown Object (File)
Apr 14 2025, 3:05 AM
Unknown Object (File)
Apr 13 2025, 9:22 PM
View All Files
Subscribers
eadler
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T8743: Unable to apply patch 'phabricator:20150116.maniphestapplicationemails.php': Table 'phabricator_spaces.spaces_namespace' doesn't exist
T8746: 20131121.repocredentials.2.mig.php fails
Commits
Restricted Diffusion Commit
rP92b73fed6b2c: Don't apply space constraints to omnipotent-viewer queries
Summary

Fixes T8743. Fixes T8746. When running queries with the omnipotent viewer and no explicit space constraints, don't add implicit space constraints.

This prevents us from fataling when running older pre-space migrations and trying to load space-aware objects.

Test Plan

Manually ran migrations with --trace, verified no WHERE spacePHID = ....

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32722.Jul 3 2015, 3:47 PM
epriestley retitled this revision from to Don't apply space constraints to omnipotent-viewer queries.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T8746: 20131121.repocredentials.2.mig.php fails, T8743: Unable to apply patch 'phabricator:20150116.maniphestapplicationemails.php': Table 'phabricator_spaces.spaces_namespace' doesn't exist.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 3 2015, 3:47 PM
eadler added a subscriber: eadler.Jul 3 2015, 4:06 PM
chad accepted this revision.Jul 3 2015, 5:48 PM
chad added a reviewer: chad.
This revision is now accepted and ready to land.Jul 3 2015, 5:48 PM
Closed by commit rP92b73fed6b2c: Don't apply space constraints to omnipotent-viewer queries (authored by epriestley, committed by epriestley). · Explain WhyJul 3 2015, 5:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
query/
policy/
10 lines

Diff 32730

View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility