Page MenuHomePhabricator

Don't apply space constraints to omnipotent-viewer queries
ClosedPublic

Authored by epriestley on Jul 3 2015, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 23, 4:57 AM
Unknown Object (File)
Fri, May 9, 6:52 PM
Unknown Object (File)
May 6 2025, 6:03 PM
Unknown Object (File)
Apr 24 2025, 5:24 AM
Unknown Object (File)
Apr 14 2025, 7:03 PM
Unknown Object (File)
Apr 14 2025, 7:21 AM
Unknown Object (File)
Apr 14 2025, 3:05 AM
Unknown Object (File)
Apr 13 2025, 9:22 PM
Subscribers

Details

Summary

Fixes T8743. Fixes T8746. When running queries with the omnipotent viewer and no explicit space constraints, don't add implicit space constraints.

This prevents us from fataling when running older pre-space migrations and trying to load space-aware objects.

Test Plan

Manually ran migrations with --trace, verified no WHERE spacePHID = ....

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't apply space constraints to omnipotent-viewer queries.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
This revision is now accepted and ready to land.Jul 3 2015, 5:48 PM
This revision was automatically updated to reflect the committed changes.