Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15375473
D14491.id35060.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D14491.id35060.diff
View Options
diff --git a/src/applications/diffusion/view/DiffusionBrowseTableView.php b/src/applications/diffusion/view/DiffusionBrowseTableView.php
--- a/src/applications/diffusion/view/DiffusionBrowseTableView.php
+++ b/src/applications/diffusion/view/DiffusionBrowseTableView.php
@@ -30,8 +30,7 @@
$rows = array();
$show_edit = false;
foreach ($this->paths as $path) {
-
- $history_link = $this->linkHistory($path->getPath());
+ $full_path = $base_path.$path->getPath();
$dir_slash = null;
$file_type = $path->getFileType();
@@ -40,11 +39,13 @@
$dir_slash = '/';
$browse_link = phutil_tag('strong', array(), $this->linkBrowse(
- $base_path.$path->getPath().$dir_slash,
+ $full_path.$dir_slash,
array(
'type' => $file_type,
'name' => $browse_text,
)));
+
+ $history_path = $full_path.'/';
} else if ($file_type == DifferentialChangeType::FILE_SUBMODULE) {
$browse_text = $path->getPath().'/';
$browse_link = phutil_tag('strong', array(), $this->linkBrowse(
@@ -55,16 +56,22 @@
'hash' => $path->getHash(),
'external' => $path->getExternalURI(),
)));
+
+ $history_path = $full_path.'/';
} else {
$browse_text = $path->getPath();
$browse_link = $this->linkBrowse(
- $base_path.$path->getPath(),
+ $full_path,
array(
'type' => $file_type,
'name' => $browse_text,
));
+
+ $history_path = $full_path;
}
+ $history_link = $this->linkHistory($history_path);
+
$dict = array(
'lint' => celerity_generate_unique_node_id(),
'commit' => celerity_generate_unique_node_id(),
@@ -73,7 +80,7 @@
'details' => celerity_generate_unique_node_id(),
);
- $need_pull[$base_path.$path->getPath().$dir_slash] = $dict;
+ $need_pull[$full_path.$dir_slash] = $dict;
foreach ($dict as $k => $uniq) {
$dict[$k] = phutil_tag('span', array('id' => $uniq), '');
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Mar 13, 11:22 PM (1 w, 23 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7383444
Default Alt Text
D14491.id35060.diff (2 KB)
Attached To
Mode
D14491: Fix history link in Diffusion non-root browse views
Attached
Detach File
Event Timeline
Log In to Comment